The default bug view has changed. See this FAQ.

Make test_XHR_timeout.js use addEventListener(..., obj, ...) instead of on* = obj

RESOLVED FIXED in mozilla14

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: peterv, Assigned: peterv)

Tracking

Trunk
mozilla14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 610585 [details] [diff] [review]
v1
Attachment #610585 - Flags: review?(khuey)
Attachment #610585 - Flags: review?(khuey) → review+
I object to this.  I had a reason for using on*.  The spec said the ontimeout attribute had to exist and map to a timeout event listener.  This patch removes the test for ontimeout working.
Ok, then we need to test that differently.  Per spec onfoo properties don't accept objects with handleEvent methods, only functions.

Comment 3

5 years ago
Yeah, kyle is right.  I should have noticed the problem in the xhr.timeout tests.
I agree - the code should've caught that... but I think that should be a separate bug.

I'd feel better if the test file itself were cloned, and the clone used the addEventListener approach.
(Assignee)

Comment 5

5 years ago
Created attachment 610603 [details] [diff] [review]
v2
Attachment #610585 - Attachment is obsolete: true
Attachment #610603 - Flags: review?(khuey)
To be clear, when we land bug 740069 this test will stop working if we don't do anything to it.

Peterv is going to post a new patch that addresses your comments.
Attachment #610603 - Flags: review?(khuey) → review+
(Assignee)

Comment 7

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/5561efcb19f2
https://hg.mozilla.org/mozilla-central/rev/5561efcb19f2
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.