Closed Bug 740467 Opened 8 years ago Closed 8 years ago

Make test_XHR_timeout.js use addEventListener(..., obj, ...) instead of on* = obj

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: peterv, Assigned: peterv)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch v1 (obsolete) — Splinter Review
No description provided.
Attachment #610585 - Flags: review?(khuey)
I object to this.  I had a reason for using on*.  The spec said the ontimeout attribute had to exist and map to a timeout event listener.  This patch removes the test for ontimeout working.
Ok, then we need to test that differently.  Per spec onfoo properties don't accept objects with handleEvent methods, only functions.
Yeah, kyle is right.  I should have noticed the problem in the xhr.timeout tests.
I agree - the code should've caught that... but I think that should be a separate bug.

I'd feel better if the test file itself were cloned, and the clone used the addEventListener approach.
Attached patch v2Splinter Review
Attachment #610585 - Attachment is obsolete: true
Attachment #610603 - Flags: review?(khuey)
To be clear, when we land bug 740069 this test will stop working if we don't do anything to it.

Peterv is going to post a new patch that addresses your comments.
https://hg.mozilla.org/mozilla-central/rev/5561efcb19f2
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.