Closed Bug 740469 Opened 8 years ago Closed 8 years ago

JSNative->JSFunction fixup should happen in DefinePropertyById, not DefineProperty

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(1 file)

We need this stuff in the dom bindings, but it seems silly to convert our JSID to a char* just to take advantage of this. Patch coming right up.
Attached patch patch. v1Splinter Review
Attaching a patch. Flagging luke for review.
Attachment #610601 - Flags: review?(luke)
Attachment #610601 - Flags: review?(luke) → review+
Looks like the try oranges were the result of the patch underneath, which was backed out on inbound.

Pushed to m-i: http://hg.mozilla.org/integration/mozilla-inbound/rev/5ed5a3e3acc4
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/5ed5a3e3acc4
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.