JSNative->JSFunction fixup should happen in DefinePropertyById, not DefineProperty

RESOLVED FIXED in mozilla14

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bholley, Assigned: bholley)

Tracking

unspecified
mozilla14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We need this stuff in the dom bindings, but it seems silly to convert our JSID to a char* just to take advantage of this. Patch coming right up.
Created attachment 610601 [details] [diff] [review]
patch. v1

Attaching a patch. Flagging luke for review.
Attachment #610601 - Flags: review?(luke)
Pushed this to try: https://tbpl.mozilla.org/?tree=Try&rev=7a2dbe5f12e4

Updated

5 years ago
Attachment #610601 - Flags: review?(luke) → review+
Looks like the try oranges were the result of the patch underneath, which was backed out on inbound.

Pushed to m-i: http://hg.mozilla.org/integration/mozilla-inbound/rev/5ed5a3e3acc4
Target Milestone: --- → mozilla14

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/5ed5a3e3acc4
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.