Closed
Bug 740469
Opened 12 years ago
Closed 12 years ago
JSNative->JSFunction fixup should happen in DefinePropertyById, not DefineProperty
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(1 file)
|
5.39 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
We need this stuff in the dom bindings, but it seems silly to convert our JSID to a char* just to take advantage of this. Patch coming right up.
|
Assignee | |
Comment 1•12 years ago
|
||
Attaching a patch. Flagging luke for review.
Attachment #610601 -
Flags: review?(luke)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Pushed this to try: https://tbpl.mozilla.org/?tree=Try&rev=7a2dbe5f12e4
|
||
Updated•12 years ago
|
Attachment #610601 -
Flags: review?(luke) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Looks like the try oranges were the result of the patch underneath, which was backed out on inbound. Pushed to m-i: http://hg.mozilla.org/integration/mozilla-inbound/rev/5ed5a3e3acc4
Target Milestone: --- → mozilla14
|
||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5ed5a3e3acc4
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•