Create nice breakpoint icons for the SourceEditor in the Debugger

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Developer Tools: Debugger
P2
normal
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: rc, Assigned: rc)

Tracking

({uiwanted})

unspecified
Firefox 15
uiwanted
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [sourceeditor][fixed-in-fx-team])

Attachments

(4 attachments, 1 obsolete attachment)

(Assignee)

Description

6 years ago
The SourceEditor should have nicer icons for showing breakpoints.
(Assignee)

Comment 1

6 years ago
Also need a "current line arrow" icon.

Updated

6 years ago
Whiteboard: [sourceeditor]
(Assignee)

Comment 2

6 years ago
cc'ing shorlander.

I'll add a screencap with the current buttons for examination.
Keywords: uiwanted
Created attachment 611937 [details]
Breakpoint Icon Mockup
(Assignee)

Comment 4

5 years ago
darn, I never did add that screencap. Do you need one?

Those icons look pretty sweet. Also, can I have that color theme for the editor? :)
(Assignee)

Comment 5

5 years ago
mihai: does this look feasible or are we stuck using n x n images in the gutter? This looks like it'd be better implemented in CSS than using an image.

Comment 6

5 years ago
(In reply to Rob Campbell [:rc] (:robcee) from comment #4)
> darn, I never did add that screencap. Do you need one?
> 
> Also, can I have that color theme for the editor?

This should happen here: bug 715472 (not sure if you meant to implement the theme here)
(In reply to Rob Campbell [:rc] (:robcee) from comment #5)
> mihai: does this look feasible or are we stuck using n x n images in the
> gutter? This looks like it'd be better implemented in CSS than using an
> image.

The AnnotationRuler used for the debugger icons does not "communicate" in any way with the LineNumberRuler, unfortunately. This code comes from upstream.

From CSS we can only change the icons and a bit of styling for the AnnotationRuler.

If we want the design as proposed by shorlander (I want it!) we need to write a bit of JS code: write our own LineNumberRuler that allows us to do what we need. I doubt this is code we need to go upstream for - we can handle our editor UI as we see fit.

Thoughts?
(Assignee)

Comment 8

5 years ago
prioritizing as P2.
Priority: -- → P2
Blocks: 753301

Updated

5 years ago
Assignee: nobody → mihai.sucan
Created attachment 627149 [details] [diff] [review]
Treetwisty as the location indicator

If we don't get new icons in time, how about using the treetwisty arrow as the current line indicator?
(Assignee)

Comment 10

5 years ago
what does that look like? I think it'll be offset won't it?
Created attachment 627924 [details]
Current icons
Created attachment 627925 [details]
The Treetwisty icon

(In reply to Rob Campbell [:rc] (:robcee) from comment #10)
> what does that look like? I think it'll be offset won't it?

Yes, I think it's a little more offset than the current icon. At least with the dumb patch that I attached.
(Assignee)

Comment 13

5 years ago
Created attachment 628358 [details] [diff] [review]
breakpoint-icons

simple patch to replace the current icons with shorlander's improved ones.

These still suffer from some funny offsets.
Assignee: mihai.sucan → rcampbell
Status: NEW → ASSIGNED
Attachment #628358 - Flags: review?(past)

Updated

5 years ago
Attachment #628358 - Flags: review?(past) → review+
Attachment #627149 - Attachment is obsolete: true
Whiteboard: [sourceeditor] → [sourceeditor][land-in-fx-team]
(Assignee)

Comment 14

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/1a1529306022
Whiteboard: [sourceeditor][land-in-fx-team] → [sourceeditor][fixed-in-fx-team]
(Assignee)

Comment 15

5 years ago
https://hg.mozilla.org/mozilla-central/rev/1a1529306022
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
You need to log in before you can comment on or make changes to this bug.