Closed Bug 740482 Opened 9 years ago Closed 9 years ago

Create nice breakpoint icons for the SourceEditor in the Debugger

Categories

(DevTools :: Debugger, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 15

People

(Reporter: rcampbell, Assigned: rcampbell)

References

Details

(Keywords: uiwanted, Whiteboard: [sourceeditor][fixed-in-fx-team])

Attachments

(4 files, 1 obsolete file)

The SourceEditor should have nicer icons for showing breakpoints.
Also need a "current line arrow" icon.
Whiteboard: [sourceeditor]
cc'ing shorlander.

I'll add a screencap with the current buttons for examination.
Keywords: uiwanted
darn, I never did add that screencap. Do you need one?

Those icons look pretty sweet. Also, can I have that color theme for the editor? :)
mihai: does this look feasible or are we stuck using n x n images in the gutter? This looks like it'd be better implemented in CSS than using an image.
(In reply to Rob Campbell [:rc] (:robcee) from comment #4)
> darn, I never did add that screencap. Do you need one?
> 
> Also, can I have that color theme for the editor?

This should happen here: bug 715472 (not sure if you meant to implement the theme here)
(In reply to Rob Campbell [:rc] (:robcee) from comment #5)
> mihai: does this look feasible or are we stuck using n x n images in the
> gutter? This looks like it'd be better implemented in CSS than using an
> image.

The AnnotationRuler used for the debugger icons does not "communicate" in any way with the LineNumberRuler, unfortunately. This code comes from upstream.

From CSS we can only change the icons and a bit of styling for the AnnotationRuler.

If we want the design as proposed by shorlander (I want it!) we need to write a bit of JS code: write our own LineNumberRuler that allows us to do what we need. I doubt this is code we need to go upstream for - we can handle our editor UI as we see fit.

Thoughts?
prioritizing as P2.
Priority: -- → P2
Assignee: nobody → mihai.sucan
If we don't get new icons in time, how about using the treetwisty arrow as the current line indicator?
what does that look like? I think it'll be offset won't it?
Attached image The Treetwisty icon
(In reply to Rob Campbell [:rc] (:robcee) from comment #10)
> what does that look like? I think it'll be offset won't it?

Yes, I think it's a little more offset than the current icon. At least with the dumb patch that I attached.
Attached patch breakpoint-iconsSplinter Review
simple patch to replace the current icons with shorlander's improved ones.

These still suffer from some funny offsets.
Assignee: mihai.sucan → rcampbell
Status: NEW → ASSIGNED
Attachment #628358 - Flags: review?(past)
Attachment #628358 - Flags: review?(past) → review+
Attachment #627149 - Attachment is obsolete: true
Whiteboard: [sourceeditor] → [sourceeditor][land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/1a1529306022
Whiteboard: [sourceeditor][land-in-fx-team] → [sourceeditor][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/1a1529306022
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.