Last Comment Bug 740515 - nsView.cpp:990:32: warning: format ‘%p’ expects argument of type ‘void*’, but argument 5 has type ‘nsIFrame*’ [-Wformat]
: nsView.cpp:990:32: warning: format ‘%p’ expects argument of type ‘void*’, but...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Event Handling (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla14
Assigned To: Daniel Holbert [:dholbert]
:
: Andrew Overholt [:overholt]
Mentors:
Depends on: 703260
Blocks: buildwarning
  Show dependency treegraph
 
Reported: 2012-03-29 11:25 PDT by Daniel Holbert [:dholbert]
Modified: 2012-03-31 19:29 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
trivial fix (972 bytes, patch)
2012-03-29 11:25 PDT, Daniel Holbert [:dholbert]
bugs: review+
Details | Diff | Splinter Review

Description Daniel Holbert [:dholbert] 2012-03-29 11:25:46 PDT
Created attachment 610612 [details] [diff] [review]
trivial fix

Build warning:
{
nsView.cpp:990:32: warning: format ‘%p’ expects argument of type ‘void*’, but argument 5 has type ‘nsIFrame*’ [-Wformat]
}

...which points to this code:
> 989   fprintf(out, " z=%d vis=%d frame=%p <\n",
> 990           mZIndex, mVis, mFrame);
http://mxr.mozilla.org/mozilla-central/source/view/src/nsView.cpp#989
which was added in bug 703260.

This just wants some static_cast<void*>() love (which is what we use elsewhere to suppress this warning).  Silly [f]printf.
Comment 1 Daniel Holbert [:dholbert] 2012-03-30 13:39:09 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/176df86aa16e
Comment 2 Ed Morley [:emorley] 2012-03-31 19:29:19 PDT
https://hg.mozilla.org/mozilla-central/rev/176df86aa16e

Note You need to log in before you can comment on or make changes to this bug.