740565 - favicons for error states are not updated

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect)

Description

[Dietrich Ayala (:dietrich)]

tried to load zimbra at one point with no connectivity, which updated the favicon to a yellow ! triangle.

i've logged in many times since, and the favicon is still the error one.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

This is probably caused by this exception that I've seen in many logs of late:

E/GeckoFavicons( 7735): Error reading favicon
E/GeckoFavicons( 7735): java.lang.IllegalArgumentException: size must be > 0
E/GeckoFavicons( 7735): 	at java.io.BufferedInputStream.<init>(BufferedInputStream.java:112)
E/GeckoFavicons( 7735): 	at org.mozilla.gecko.Favicons$LoadFaviconTask.downloadFavicon(Favicons.java:291)
E/GeckoFavicons( 7735): 	at org.mozilla.gecko.Favicons$LoadFaviconTask.doInBackground(Favicons.java:369)
E/GeckoFavicons( 7735): 	at org.mozilla.gecko.Favicons$LoadFaviconTask.doInBackground(Favicons.java:226)
E/GeckoFavicons( 7735): 	at android.os.AsyncTask$2.call(AsyncTask.java:185)
E/GeckoFavicons( 7735): 	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:305)
E/GeckoFavicons( 7735): 	at java.util.concurrent.FutureTask.run(FutureTask.java:137)
E/GeckoFavicons( 7735): 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1068)
E/GeckoFavicons( 7735): 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:561)
E/GeckoFavicons( 7735): 	at java.lang.Thread.run(Thread.java:1096)

Comment 2

[Aaron Train [:aaronmt]]

soft-block nom?

Comment 3

[Brian Nicholson (:bnicholson)]

I tried reproducing this from the description in comment 1 (load Zimbra without connectivity, then with connectivity), but the favicon gets updated when the page loads. The favicon code changed in bug 726001, which was fixed after this one was reported. Dietrich, are you still having this issue?

Comment 4

[Paul Feher]

This is also reproducible on:
Nightly Fennec 14.0a1 (2012-04-17)
Device: HTC Desire Z
OS: Android 2.3.3

Steps to reproduce:
1. Turn off the internet connection.
2. Open fennec and load a page(for example yahoo.com).
3. After the error message tap on the home button.
4. Turn on the internet connection.
5. Open fennec and reload the page.

The page is properly loaded but the favicon is not updated. The error favicon is still displayed.

Comment 5

[Brian Nicholson (:bnicholson)]

Looks like this bug can also affect pages other than the ones that had the error:

1) Go to some invalid URI (e.g., about:foo)
2) Search "bananas" in the AwesomeScreen

This will do a Google search, but the error favicon stays.

Comment 6

[Brian Nicholson (:bnicholson)]

(In reply to Brian Nicholson (:bnicholson) from comment #5)
> Looks like this bug can also affect pages other than the ones that had the
> error:
> 
> 1) Go to some invalid URI (e.g., about:foo)
> 2) Search "bananas" in the AwesomeScreen
> 
> This will do a Google search, but the error favicon stays.

Nevermind; this case was caused by a patch from bug 746380.

Comment 7

[Brian Nicholson (:bnicholson)]

Dietrich said he hasn't seen this problem lately. Paul, your STR don't work for me - can you still reproduce?

Comment 8

[Paul Feher]

This is not reproducible anymore.
WFM on:Nightly Fennec 14.0a1 (2012-05-02)
Device: HTC Desire Z
OS: Android 2.3.3