Last Comment Bug 740627 - "ASSERTION: viewport height must be nonnegative!"
: "ASSERTION: viewport height must be nonnegative!"
Status: RESOLVED FIXED
: assertion, testcase
Product: Core
Classification: Components
Component: SVG (show other bugs)
: Trunk
: x86_64 Mac OS X
: -- normal (vote)
: mozilla14
Assigned To: Robert Longson
:
Mentors:
Depends on:
Blocks: 344905 594645
  Show dependency treegraph
 
Reported: 2012-03-29 15:21 PDT by Jesse Ruderman
Modified: 2012-03-31 19:16 PDT (History)
4 users (show)
longsonr: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
testcase (166 bytes, image/svg+xml)
2012-03-29 15:21 PDT, Jesse Ruderman
no flags Details
stack trace (9.87 KB, text/plain)
2012-03-29 15:22 PDT, Jesse Ruderman
no flags Details
patch (2.91 KB, patch)
2012-03-30 07:58 PDT, Robert Longson
dholbert: review+
Details | Diff | Review

Description Jesse Ruderman 2012-03-29 15:21:59 PDT
Created attachment 610718 [details]
testcase

###!!! ASSERTION: viewport height must be nonnegative!: 'aViewportHeight >= 0', file layout/svg/base/src/nsSVGUtils.cpp, line 957
Comment 1 Jesse Ruderman 2012-03-29 15:22:44 PDT
Created attachment 610719 [details]
stack trace
Comment 2 Cameron McCormack (:heycam) 2012-03-29 16:20:51 PDT
I think nsSVGPatternFrame::GetPatternRect should be indicating there's an error if width="" or height="" is <= 0 and cause the pattern not to render (and causing a fallback colour to be used if one was specified?).
Comment 3 Cameron McCormack (:heycam) 2012-03-29 17:14:58 PDT
Although maybe if width/height == 0 nothing should be painted, while if it's <= 0 we should fall back.
Comment 4 Robert Longson 2012-03-30 07:58:52 PDT
Created attachment 610882 [details] [diff] [review]
patch
Comment 5 Daniel Holbert [:dholbert] 2012-03-30 10:39:15 PDT
Comment on attachment 610882 [details] [diff] [review]
patch

Might be good to add a second crashtest 740627-2.svg with width="-65%" (instead of height)

In any case, looks great -- r=me
Comment 7 Ed Morley [:emorley] 2012-03-31 05:38:53 PDT
Ms2ger backed out for burning the tree (in https://hg.mozilla.org/integration/mozilla-inbound/rev/2195f743e7dc), but now believed to be delayed bustage from a prior landing. Can reland once the tree is green (but may be after I am afk, so posting this in case I'm not able to reland for you); sorry for the hassle.
Comment 8 Ed Morley [:emorley] 2012-03-31 06:56:41 PDT
Relanded:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f77f15134c2
Comment 9 Robert Longson 2012-03-31 07:10:00 PDT
Thank you for relanding.
Comment 10 Ed Morley [:emorley] 2012-03-31 19:16:09 PDT
No problem :-)

https://hg.mozilla.org/mozilla-central/rev/8f77f15134c2

Note You need to log in before you can comment on or make changes to this bug.