"ASSERTION: viewport height must be nonnegative!"

RESOLVED FIXED in mozilla14

Status

()

Core
SVG
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jesse Ruderman, Assigned: Robert Longson)

Tracking

(Blocks: 2 bugs, {assertion, testcase})

Trunk
mozilla14
x86_64
Mac OS X
assertion, testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

6 years ago
Created attachment 610718 [details]
testcase

###!!! ASSERTION: viewport height must be nonnegative!: 'aViewportHeight >= 0', file layout/svg/base/src/nsSVGUtils.cpp, line 957
(Reporter)

Comment 1

6 years ago
Created attachment 610719 [details]
stack trace
I think nsSVGPatternFrame::GetPatternRect should be indicating there's an error if width="" or height="" is <= 0 and cause the pattern not to render (and causing a fallback colour to be used if one was specified?).
Although maybe if width/height == 0 nothing should be painted, while if it's <= 0 we should fall back.
(Assignee)

Updated

6 years ago
Assignee: nobody → longsonr
(Assignee)

Comment 4

6 years ago
Created attachment 610882 [details] [diff] [review]
patch
Attachment #610882 - Flags: review?(dholbert)
Comment on attachment 610882 [details] [diff] [review]
patch

Might be good to add a second crashtest 740627-2.svg with width="-65%" (instead of height)

In any case, looks great -- r=me
Attachment #610882 - Flags: review?(dholbert) → review+
(Assignee)

Comment 6

6 years ago
pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/a329aa4bc026
Flags: in-testsuite+
Target Milestone: --- → mozilla14

Comment 7

6 years ago
Ms2ger backed out for burning the tree (in https://hg.mozilla.org/integration/mozilla-inbound/rev/2195f743e7dc), but now believed to be delayed bustage from a prior landing. Can reland once the tree is green (but may be after I am afk, so posting this in case I'm not able to reland for you); sorry for the hassle.

Comment 8

6 years ago
Relanded:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f77f15134c2
(Assignee)

Comment 9

6 years ago
Thank you for relanding.
No problem :-)

https://hg.mozilla.org/mozilla-central/rev/8f77f15134c2
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.