740702 - nsHyperTextAccessible::GetDOMPointByFrameOffset should take nsAccessible*

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

1) replace nsIAccessible to nsAccessible in GetDOMPointByFrameOffset (http://mxr.mozilla.org/mozilla-central/source/accessible/src/html/nsHyperTextAccessible.h#393)

2) replace the following block in nsHyperTextAccessible::GetDOMPointByFrameOffset:

nsCOMPtr<nsIDOMNode> DOMNode;
aAccessible->GetDOMNode(getter_AddRefs(DOMNode));
nsCOMPtr<nsIContent> content(do_QueryInterface(DOMNode));
NS_ENSURE_STATE(content);

nsCOMPtr<nsIContent> parent(content->GetParent());
NS_ENSURE_STATE(parent);

to

NS_ASSERTION(aAccessible->IsDoc(), "Shouldn't be called on document accessible!");

nsIContent* content = aAccessible->GetContent();
NS_ASSERTION(content, "Shouldn't operate on defunct accessible!");

nsIContent* parentContent = content->GetParent();

Comment 1

[Max Li [:maxli]]

Attachment: Patch (v1)

Comment 2

[Trevor Saunders (:tbsaunde)]

Comment on attachment 615091 [details] [diff] [review]
Patch (v1)

> nsHyperTextAccessible::GetDOMPointByFrameOffset(nsIFrame *aFrame,
>                                                 PRInt32 aOffset,
>-                                                nsIAccessible *aAccessible,
>+                                                nsAccessible *aAccessible,

type* name here and below.

>+    NS_ASSERTION(aAccessible->IsDoc(), 
>+                 "Shouldn't be called on document accessible!");

that should be !aAccessible->IsDoc()

Comment 3

[Max Li [:maxli]]

Attachment: Patch (v2)

Comment 4

[alexander :surkov (:asurkov)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eae5257fcaca

Comment 5

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/eae5257fcaca