pinch and zoom don't work on the Windows with touch input displays

RESOLVED FIXED in Firefox 14

Status

()

Firefox
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jimm, Assigned: jimm)

Tracking

unspecified
Firefox 15
x86_64
Windows 8
Points:
---

Firefox Tracking Flags

(firefox14 fixed, firefox15 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
This could be in widget or something higher up. We added touch input support back when win7 was released, this seems to have broken.

STR:

1) open a web page on the desktop
2) pinch or zoom the page

result: nothing happen.

Updated

5 years ago
Component: Tabbed Browser → General
QA Contact: tabbed.browser → general
(Assignee)

Updated

5 years ago
Duplicate of this bug: 750647
(Assignee)

Updated

5 years ago
Component: General → Widget: Win32
Product: Firefox → Core
QA Contact: general → win32
(Assignee)

Updated

5 years ago
Blocks: 613909
(Assignee)

Updated

5 years ago
Assignee: nobody → jmathies
Component: Widget: Win32 → General
Product: Core → Firefox
QA Contact: win32 → general
(Assignee)

Comment 2

5 years ago
Created attachment 628060 [details] [diff] [review]
fix
(Assignee)

Comment 3

5 years ago
Comment on attachment 628060 [details] [diff] [review]
fix

Reverting changes in bug 613909 for Windows.
Attachment #628060 - Flags: review?(dao)
(Assignee)

Updated

5 years ago
Summary: pinch and zoom don't work on win8 desktop → pinch and zoom don't work on the Windows with touch input displays
Comment on attachment 628060 [details] [diff] [review]
fix

Please use ifdef instead of ifndef, swapping these two sections. Can you also add a comment explaining why this varies across OSes?
(Assignee)

Comment 5

5 years ago
Created attachment 628275 [details] [diff] [review]
patch

Updated.
Attachment #628060 - Attachment is obsolete: true
Attachment #628060 - Flags: review?(dao)
Attachment #628275 - Flags: review?(dao)

Updated

5 years ago
Attachment #628275 - Flags: review?(dao) → review+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b9fd71b7bde2
https://hg.mozilla.org/mozilla-central/rev/b9fd71b7bde2
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
(Assignee)

Comment 8

5 years ago
Comment on attachment 628275 [details] [diff] [review]
patch

This change enables functionality we mistakenly disabled about a year ago for windows touch input displays. Unfortunately once disabled, it stays disabled unless the user manually edits config settings.

Microsoft will have a fresh preview release of win8 due out in the next few weeks, so I would like to get this out to beta in the hope that this functionality will be available for fresh installs on the new os rev.
Attachment #628275 - Flags: approval-mozilla-beta?
Attachment #628275 - Flags: approval-mozilla-aurora?

Comment 9

5 years ago
Comment on attachment 628275 [details] [diff] [review]
patch

[Triage Comment]
This is too late for FF13, but appears to be low risk enough to approve for Aurora 14.
Attachment #628275 - Flags: approval-mozilla-beta?
Attachment #628275 - Flags: approval-mozilla-beta-
Attachment #628275 - Flags: approval-mozilla-aurora?
Attachment #628275 - Flags: approval-mozilla-aurora+
(Assignee)

Comment 10

5 years ago
http://hg.mozilla.org/releases/mozilla-aurora/rev/b61d1ddc8550
status-firefox14: --- → fixed
status-firefox15: --- → fixed
You need to log in before you can comment on or make changes to this bug.