Closed Bug 740721 Opened 11 years ago Closed 11 years ago

pinch and zoom don't work on the Windows with touch input displays

Categories

(Firefox :: General, defect)

x86_64
Windows 8
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 15
Tracking Status
firefox14 --- fixed
firefox15 --- fixed

People

(Reporter: jimm, Assigned: jimm)

References

Details

Attachments

(1 file, 1 obsolete file)

This could be in widget or something higher up. We added touch input support back when win7 was released, this seems to have broken.

STR:

1) open a web page on the desktop
2) pinch or zoom the page

result: nothing happen.
Component: Tabbed Browser → General
QA Contact: tabbed.browser → general
Duplicate of this bug: 750647
Component: General → Widget: Win32
Product: Firefox → Core
QA Contact: general → win32
Blocks: 613909
Assignee: nobody → jmathies
Component: Widget: Win32 → General
Product: Core → Firefox
QA Contact: win32 → general
Attached patch fix (obsolete) — Splinter Review
Comment on attachment 628060 [details] [diff] [review]
fix

Reverting changes in bug 613909 for Windows.
Attachment #628060 - Flags: review?(dao)
Summary: pinch and zoom don't work on win8 desktop → pinch and zoom don't work on the Windows with touch input displays
Comment on attachment 628060 [details] [diff] [review]
fix

Please use ifdef instead of ifndef, swapping these two sections. Can you also add a comment explaining why this varies across OSes?
Attached patch patchSplinter Review
Updated.
Attachment #628060 - Attachment is obsolete: true
Attachment #628060 - Flags: review?(dao)
Attachment #628275 - Flags: review?(dao)
Attachment #628275 - Flags: review?(dao) → review+
https://hg.mozilla.org/mozilla-central/rev/b9fd71b7bde2
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
Comment on attachment 628275 [details] [diff] [review]
patch

This change enables functionality we mistakenly disabled about a year ago for windows touch input displays. Unfortunately once disabled, it stays disabled unless the user manually edits config settings.

Microsoft will have a fresh preview release of win8 due out in the next few weeks, so I would like to get this out to beta in the hope that this functionality will be available for fresh installs on the new os rev.
Attachment #628275 - Flags: approval-mozilla-beta?
Attachment #628275 - Flags: approval-mozilla-aurora?
Comment on attachment 628275 [details] [diff] [review]
patch

[Triage Comment]
This is too late for FF13, but appears to be low risk enough to approve for Aurora 14.
Attachment #628275 - Flags: approval-mozilla-beta?
Attachment #628275 - Flags: approval-mozilla-beta-
Attachment #628275 - Flags: approval-mozilla-aurora?
Attachment #628275 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.