74098 - nsILDAPOperation.searchExt lacking attributes parameter

Status: VERIFIED FIXED

(Directory :: LDAP XPCOM SDK, defect, P2)

Description

[Paul.Sandoz]

The nsILDAPURL interface now has support for the return attributes parameter.

It would be good if this could be used in conjuction with the 
nsILDAPOperation.seatchExt method which is currently lacking support for return 
attributes.

In addition, as per comment by Dan Mosedale, it will optmize
autocomplete searches.

Comment 1

[yulian chang]

reassign to Olga as QA contact

Comment 2

[Leif Hedstrom]

Attachment: Changes to nsILDAPOperataion and implementation

Comment 3

[Leif Hedstrom]

This patch doesn't actually enable the autocomplete session to limit the search
results to a set of attributes. However, I've verified the functionality with a
hardcoded set of attributes in the autocomplete, and it does indeed limit the
results to the requested attributes.

Dmose, review please.

-- Leif

Comment 4

[Leif Hedstrom]

Attachment: 2nd patch

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

r=[e-mail]

Comment 6

[Leif Hedstrom]

mscott, can you SR this please?

thanks,

-- leif

Comment 7

[Jussi-Pekka Mantere]

PDT+ per 6/12 mtg.

Comment 8

[Scott MacGregor]

sr=mscott

Comment 9

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 10

[Leif Hedstrom]

Checked in. (Many thanks to srilatha for testing on Mac and PC)

-- Leif

Comment 11

[Dan Mosedale (:dmosedale, :dmose)]

Reopening, as there's still one piece left to do: change the autocomplete caller
to do the right thing regarding this parameter.

Comment 12

[Dan Mosedale (:dmosedale, :dmose)]

Taking, since this final bit is in my code.

Comment 13

[Dan Mosedale (:dmosedale, :dmose)]

I'm attaching a patch that gives the outputFormat parser the ability to work in
two modes: one generates an autocomplete item (like the existing code in the
tree does), and the other builds up an XPCOM array of the attributes needed by
outputFormat.  Whenever SetOutputFormat is called, this array is built up and
cached in the session.  Whenever SearchExt() is called, this array is used to
limit the attributes requested.

Comment 14

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: convert nsLDAPAutoCompleteSession to only request needed attrs

Comment 15

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: nsLDAPAutoCompleteSession patch, v2

Comment 16

[Dan Mosedale (:dmosedale, :dmose)]

Tiny tweak to the patch suggested by dougt eliminates unnecessary logic around
freeing of mSearchAttrs.

Comment 17

[Doug Turner (:dougt)]

r=

Comment 18

[Dan Mosedale (:dmosedale, :dmose)]

dougt said in chat that it's okay to use his stamp as sr=, so i'm gonna do that.

Comment 19

[Dan Mosedale (:dmosedale, :dmose)]

nsLDAPAutoCompleteSession patch has been tested on Mac, Windows, Linux debug
builds, as well as commercial linux optimized builds.

Comment 20

[Jean-Francois Ducarroz]

looks good, R=ducarroz

Comment 21

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 22

[Dan Mosedale (:dmosedale, :dmose)]

Fix checked in.

Comment 23

[olga charapaev]

code is in, marking as verified