Closed
Bug 740996
Opened 12 years ago
Closed 12 years ago
[jsdbg2] Debugger.prototype.addDebuggee should only accept global objects
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 796073
mozilla14
People
(Reporter: jimb, Unassigned)
References
Details
Attachments
(1 file)
Once bug 740542 is landed, Debugger.prototype.addDebuggee shouldn't act as a Debugger.Object factory, as Debugger.prototype.wrap does that job better. A lot of tests use addDebuggee this way; they'll need to be changed.
Reporter | ||
Comment 1•12 years ago
|
||
Reporter | ||
Comment 3•12 years ago
|
||
Try: https://tbpl.mozilla.org/?tree=Try&rev=835ca0a926b1 Looks good.
Reporter | ||
Comment 4•12 years ago
|
||
(Apologies for an especially mind-numbing r?.)
Comment 5•12 years ago
|
||
Comment on attachment 611247 [details] [diff] [review] Make Debugger.prototype.addDebuggee return undefined; change tests to use Debugger.prototype.wrap. Clearing review flag since bug 741615 should precede this now.
Attachment #611247 -
Flags: review?(jorendorff)
Reporter | ||
Comment 6•12 years ago
|
||
With bug 741615 landed, our only general-purpose Debugger.Object factory is Debugger.Object.prototype.makeDebuggeeValue, meaning that one must have an initial Debugger.Object before one can produce others at will. It would make sense, then, if addDebuggee continued to return a Debugger.Object. We can still tighten up its semantics by restricting it to operate only on actual global objects.
Summary: [jsdbg2] Debugger.prototype.addDebuggee should not be a wrapper factory → [jsdbg2] Debugger.prototype.addDebuggee should only accept global objects
Reporter | ||
Updated•12 years ago
|
Assignee: jimb → general
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
Target Milestone: --- → mozilla14
Version: Trunk → 16 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•