All users were logged out of Bugzilla on October 13th, 2018
Once bug 740542 is landed, Debugger.prototype.addDebuggee shouldn't act as a Debugger.Object factory, as Debugger.prototype.wrap does that job better. A lot of tests use addDebuggee this way; they'll need to be changed.
Created attachment 611247 [details] [diff] [review] Make Debugger.prototype.addDebuggee return undefined; change tests to use Debugger.prototype.wrap.
Assignee: general → jimb
Status: NEW → ASSIGNED
FOLLOWUP BUG IS FOLLOWED UP UPON
Try: https://tbpl.mozilla.org/?tree=Try&rev=835ca0a926b1 Looks good.
(Apologies for an especially mind-numbing r?.)
Comment on attachment 611247 [details] [diff] [review] Make Debugger.prototype.addDebuggee return undefined; change tests to use Debugger.prototype.wrap. Clearing review flag since bug 741615 should precede this now.
With bug 741615 landed, our only general-purpose Debugger.Object factory is Debugger.Object.prototype.makeDebuggeeValue, meaning that one must have an initial Debugger.Object before one can produce others at will. It would make sense, then, if addDebuggee continued to return a Debugger.Object. We can still tighten up its semantics by restricting it to operate only on actual global objects.
Summary: [jsdbg2] Debugger.prototype.addDebuggee should not be a wrapper factory → [jsdbg2] Debugger.prototype.addDebuggee should only accept global objects
Assignee: jimb → general
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → DUPLICATE
Target Milestone: --- → mozilla14
Version: Trunk → 16 Branch
Duplicate of bug: 796073
You need to log in before you can comment on or make changes to this bug.