Closed Bug 741010 Opened 12 years ago Closed 12 years ago

Don't save favicon if loaded from DB

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 14

People

(Reporter: bnicholson, Assigned: bnicholson)

Details

Attachments

(1 file)

patch
1.54 KB, patch
mfinkle
: review+
Details | Diff | Splinter Review 
We currently store every loaded favicon to the DB - even if that favicon just came from the DB itself. We only need to update the DB if the favicon was downloaded.
Attached patch patch — — Splinter Review 

        Attachment #611084 -
        Flags: review?(mark.finkle)

    
    

    
  
Comment on attachment 611084 [details] [diff] [review]
patch

Do we have any tests for favicons? If not, let's file a bug to add a few.

        Attachment #611084 -
        Flags: review?(mark.finkle) → review+

    
    

    
  
(In reply to Mark Finkle (:mfinkle) from comment #2)
> Comment on attachment 611084 [details] [diff] [review]
> patch
> 
> Do we have any tests for favicons? If not, let's file a bug to add a few.

No, we don't have tests for the stuff in Favicons.java. We definitely should.

    
    

    
  
Filed bug 741657.

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/5f02ed277424
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
Product: Firefox for Android → Firefox for Android Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: