Closed
Bug 741010
Opened 13 years ago
Closed 13 years ago
Don't save favicon if loaded from DB
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 14
People
(Reporter: bnicholson, Assigned: bnicholson)
Details
Attachments
(1 file)
|
1.54 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
We currently store every loaded favicon to the DB - even if that favicon just came from the DB itself. We only need to update the DB if the favicon was downloaded.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #611084 -
Flags: review?(mark.finkle)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 611084 [details] [diff] [review]
patch
Do we have any tests for favicons? If not, let's file a bug to add a few.
Attachment #611084 -
Flags: review?(mark.finkle) → review+
|
||
Comment 3•13 years ago
|
||
(In reply to Mark Finkle (:mfinkle) from comment #2)
> Comment on attachment 611084 [details] [diff] [review]
> patch
>
> Do we have any tests for favicons? If not, let's file a bug to add a few.
No, we don't have tests for the stuff in Favicons.java. We definitely should.
|
|
Assignee | |
Comment 4•13 years ago
|
||
Filed bug 741657.
|
|
Assignee | |
Comment 5•13 years ago
|
||
|
||
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•