Don't save favicon if loaded from DB

RESOLVED FIXED in Firefox 14

Status

()

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: bnicholson, Assigned: bnicholson)

Tracking

unspecified
Firefox 14
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We currently store every loaded favicon to the DB - even if that favicon just came from the DB itself. We only need to update the DB if the favicon was downloaded.
Posted patch patchSplinter Review
Attachment #611084 - Flags: review?(mark.finkle)
Comment on attachment 611084 [details] [diff] [review]
patch

Do we have any tests for favicons? If not, let's file a bug to add a few.
Attachment #611084 - Flags: review?(mark.finkle) → review+
(In reply to Mark Finkle (:mfinkle) from comment #2)
> Comment on attachment 611084 [details] [diff] [review]
> patch
> 
> Do we have any tests for favicons? If not, let's file a bug to add a few.

No, we don't have tests for the stuff in Favicons.java. We definitely should.
Filed bug 741657.
https://hg.mozilla.org/mozilla-central/rev/5f02ed277424
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
You need to log in before you can comment on or make changes to this bug.