The default bug view has changed. See this FAQ.

Dumb down mt touchscreen detection

RESOLVED FIXED in mozilla14

Status

()

Core
Widget
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mwu, Assigned: mwu)

Tracking

Trunk
mozilla14
All
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
The mt touchscreen detection in EventHub.cpp tries to be too smart and breaks akami/maguro. Let's dumb it down until akami/maguro switch to ICS.
(Assignee)

Updated

5 years ago
Blocks: 736901
(Assignee)

Comment 1

5 years ago
Created attachment 611119 [details] [diff] [review]
Dumb down mt touchscreen detection
Attachment #611119 - Flags: review?(jones.chris.g)
Comment on attachment 611119 [details] [diff] [review]
Dumb down mt touchscreen detection

Please document why this check is being removed.
Attachment #611119 - Flags: review?(jones.chris.g) → review+
Hardware buttons do not work on akami. 

I/InputReader(   83): Device reconfigured: id=6, name='ft5x0x_ts', surface size is now 320x480, mode is 1
W/InputReader(   83):   VirtualKey 139: could not obtain key code, ignoring
W/InputReader(   83):   VirtualKey 102: could not obtain key code, ignoring
W/InputReader(   83):   VirtualKey 217: could not obtain key code, ignoring
W/InputReader(   83):   VirtualKey 158: could not obtain key code, ignoring

Are these messages related to the problem?

Not sure if this is the best place to report that problem or if I should file a new bug.
Likely related, yes.

You can try this patch out on akami and see if it fixes the bug --- download the patch, then |git apply| it to your gecko subdirectory in a b2g checkout.
I tried this patch out before reporting the problem. The patch solves the problem regarding the touchscreen (see [1]) but there is still something wrong with the hardware buttons.

[1] https://github.com/andreasgal/B2G/issues/254
OK.  Please file a separate bug.
Hi, attachment 611119 [details] [diff] [review] solves the problem I bumped into in bug 740238 comment 7. With it, Akami's screenlock works as normal.
(Assignee)

Comment 8

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff3f6dc55472
Target Milestone: --- → mozilla14

Comment 9

5 years ago
I have applied this patch but the issue's still there for touchscreens. Hardware buttons are responsive but touchscreen reports no input. (htc bravo).
https://hg.mozilla.org/mozilla-central/rev/ff3f6dc55472
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.