741052 - crash in mozilla::FileBlockCache::Close

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Scoobidiver (away)]

It first appeared in 14.0a1/20120330. The regression range is:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1965a2c89d61&tochange=92fe907ddac8
It's likely caused by bug 736342.

Signature 	mozilla::FileBlockCache::Close() More Reports Search
UUID	eac0b951-924c-4bfe-b3bd-6d6a52120331
Date Processed	2012-03-31 00:45:14
Uptime	179
Last Crash	3.1 minutes before submission
Install Age	5.5 hours since version was first installed.
Install Time	2012-03-30 19:13:09
Product	Firefox
Version	14.0a1
Build ID	20120330031146
Release Channel	nightly
OS	Windows NT
OS Version	5.1.2600 Service Pack 3
Build Architecture	x86
Build Architecture Info	GenuineIntel family 15 model 6 stepping 5
Crash Reason	EXCEPTION_ACCESS_VIOLATION_READ
Crash Address	0x20
App Notes 	
AdapterVendorID: 0x8086, AdapterDeviceID: 0x2772, AdapterSubsysID: 0d47105b, AdapterDriverVersion: 6.14.10.4704
D3D10 Layers? D3D10 Layers- D3D9 Layers? D3D9 Layers- 
Processor Notes 	WARNING: JSON file missing Add-ons
EMCheckCompatibility	False	
Total Virtual Memory	2147352576
Available Virtual Memory	1937018880
System Memory Use Percentage	67
Available Page File	1725145088
Available Physical Memory	348639232

Frame 	Module 	Signature 	Source
0 	xul.dll 	mozilla::FileBlockCache::Close 	content/media/FileBlockCache.cpp:61
1 	xul.dll 	nsMediaCache::~nsMediaCache 	content/media/nsMediaCache.cpp:151
2 	xul.dll 	nsMediaCache::`scalar deleting destructor' 	
3 	xul.dll 	InitMediaCache 	content/media/nsMediaCache.cpp:671
4 	xul.dll 	nsMediaCacheStream::Init 	content/media/nsMediaCache.cpp:2291
5 	xul.dll 	mozilla::ChannelMediaResource::Open 	content/media/MediaResource.cpp:422
6 	xul.dll 	nsBuiltinDecoder::Load 	content/media/nsBuiltinDecoder.cpp:193
7 	xul.dll 	nsHTMLMediaElement::InitializeDecoderForChannel 	content/html/content/src/nsHTMLMediaElement.cpp:2083
8 	xul.dll 	nsHTMLMediaElement::MediaLoadListener::OnStartRequest 	content/html/content/src/nsHTMLMediaElement.cpp:352
9 	xul.dll 	nsHttpChannel::CallOnStartRequest 	netwerk/protocol/http/nsHttpChannel.cpp:772
10 	xul.dll 	nsHttpChannel::ContinueProcessNormal 	netwerk/protocol/http/nsHttpChannel.cpp:1273
11 	xul.dll 	nsHttpChannel::ProcessNormal 	netwerk/protocol/http/nsHttpChannel.cpp:1210
12 	xul.dll 	nsHttpChannelAuthProvider::Release 	netwerk/protocol/http/nsHttpChannelAuthProvider.cpp:1317
13 	xul.dll 	nsHttpChannel::ProcessResponse 	netwerk/protocol/http/nsHttpChannel.cpp:1052
14 	nspr4.dll 	_MD_CURRENT_THREAD 	nsprpub/pr/src/md/windows/w95thred.c:308
15 	nspr4.dll 	_MD_CURRENT_THREAD 	nsprpub/pr/src/md/windows/w95thred.c:308
16 	nspr4.dll 	PR_Unlock 	nsprpub/pr/src/threads/combined/prulock.c:347
17 	xul.dll 	nsHttpChannel::OnStartRequest 	netwerk/protocol/http/nsHttpChannel.cpp:4316
18 	xul.dll 	nsInputStreamPump::OnStateStart 	netwerk/base/src/nsInputStreamPump.cpp:444
19 	xul.dll 	nsInputStreamPump::OnInputStreamReady 	netwerk/base/src/nsInputStreamPump.cpp:399
20 	xul.dll 	nsInputStreamReadyEvent::Run 	xpcom/io/nsStreamUtils.cpp:114
21 	xul.dll 	nsThread::ProcessNextEvent 	xpcom/threads/nsThread.cpp:656
22 	xul.dll 	mozilla::ipc::MessagePump::Run 	ipc/glue/MessagePump.cpp:134
23 	xul.dll 	MessageLoop::RunHandler 	ipc/chromium/src/base/message_loop.cc:201
24 	xul.dll 	MessageLoop::Run 	ipc/chromium/src/base/message_loop.cc:175
25 	xul.dll 	nsBaseAppShell::Run 	widget/xpwidgets/nsBaseAppShell.cpp:189
26 	xul.dll 	nsAppShell::Run 	widget/windows/nsAppShell.cpp:267
27 	xul.dll 	nsAppStartup::Run 	toolkit/components/startup/nsAppStartup.cpp:295
28 	xul.dll 	XREMain::XRE_mainRun 	toolkit/xre/nsAppRunner.cpp:3770
29 	xul.dll 	XREMain::XRE_main 	toolkit/xre/nsAppRunner.cpp:3847
30 	xul.dll 	XRE_main 	toolkit/xre/nsAppRunner.cpp:3923
31 	firefox.exe 	wmain 	toolkit/xre/nsWindowsWMain.cpp:107
32 	firefox.exe 	__tmainCRTStartup 	crtexe.c:552
33 	kernel32.dll 	BaseProcessStart 	

More reports at:
https://crash-stats.mozilla.com/report/list?signature=mozilla%3A%3AFileBlockCache%3A%3AClose%28%29

Comment 1

[Josh Matthews [:jdm]]

nsMediaCache::Init is failing before mFileCache is initialized, so the nsMediaCache destructor attempts to dereference a null pointer.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch: Add null check

Simple null check.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0dde67a8f4ea

Comment 4

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/0dde67a8f4ea