Closed
Bug 741068
Opened 13 years ago
Closed 13 years ago
"err is not defined" at "nsSuiteGlue.js line: 752"
Categories
(SeaMonkey :: Bookmarks & History, defect, P3)
SeaMonkey
Bookmarks & History
Tracking
(seamonkey2.8 wontfix, seamonkey2.9 fixed, seamonkey2.10 fixed)
VERIFIED
FIXED
seamonkey2.11
People
(Reporter: sgautherie, Assigned: sgautherie)
References
()
Details
Attachments
(2 files)
1.24 KB,
patch
|
Callek
:
review+
philip.chee
:
approval-comm-aurora+
philip.chee
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
(Bv1) nsSuiteGlue.js: Fix wrong object ('this', not 'importObserver')
[Checked in: Comments 7 and 9]
1.38 KB,
patch
|
kairo
:
review+
kairo
:
approval-comm-aurora+
kairo
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1333157656.1333161682.31203.gz&fulltext=1
WINNT 5.2 comm-central-trunk debug test mochitests-3/5 on 2012/03/30 18:34:16
{
* Call to xpconnect wrapped JSObject produced this error: *
[Exception... "'[JavaScript Error: "err is not defined" {file: "resource:///components/nsSuiteGlue.js" line: 752}]' when calling method: [nsIObserver::observe]" nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)" location: "<unknown>" data: yes]
}
Flags: in-testsuite-
Assignee | ||
Comment 1•13 years ago
|
||
FF nsBrowserGlue.js uses 'err': you changed one but not the other.
Attachment #611148 -
Flags: review?(kairo)
Updated•13 years ago
|
Attachment #611148 -
Flags: review?(kairo) → review+
Assignee | ||
Comment 2•13 years ago
|
||
Comment on attachment 611148 [details] [diff] [review]
(Av1) nsSuiteGlue.js: Fix typo ('ex', not 'err')
[Checked in: Comments 2 and 6]
http://hg.mozilla.org/comm-central/rev/0fbde674fbb2
[Approval Request Comment]
As we hit this case on trunk, let's fix it on branches too, fwiw.
Attachment #611148 -
Attachment description: (Av1) nsSuiteGlue.js: Fix typo ('ex', not 'err') → (Av1) nsSuiteGlue.js: Fix typo ('ex', not 'err')
[Checked in: Comment 2]
Attachment #611148 -
Flags: approval-comm-beta?
Attachment #611148 -
Flags: approval-comm-aurora?
Assignee | ||
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 3•13 years ago
|
||
Comment on attachment 611148 [details] [diff] [review]
(Av1) nsSuiteGlue.js: Fix typo ('ex', not 'err')
[Checked in: Comments 2 and 6]
Typo fix. a=me.
Attachment #611148 -
Flags: approval-comm-beta?
Attachment #611148 -
Flags: approval-comm-beta+
Attachment #611148 -
Flags: approval-comm-aurora?
Attachment #611148 -
Flags: approval-comm-aurora+
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Whiteboard: [c-n: 0fbde674fbb2 to c-a and c-b]
Assignee | ||
Comment 4•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1333310123.1333313717.4786.gz&fulltext=1
WINNT 5.2 comm-central-trunk debug test mochitests-3/5 on 2012/04/01 12:55:23
{
* Call to xpconnect wrapped JSObject produced this error: *
[Exception... "'[JavaScript Error: "importObserver is not defined" {file: "resource:///components/nsSuiteGlue.js" line: 753}]' when calling method: [nsIObserver::observe]" nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)" location: "<unknown>" data: yes]
}
V.Fixed wrt patch A.
Assignee | ||
Comment 5•13 years ago
|
||
I don't know where these 'importObserver' came from: FF never had them.
[Approval Request Comment]
As we hit this case on trunk (probably because this code/feature is being removed from Toolkit), let's fix it on branches too, fwiw.
Attachment #611402 -
Flags: review?(kairo)
Attachment #611402 -
Flags: approval-comm-beta?
Attachment #611402 -
Flags: approval-comm-aurora?
Comment 6•13 years ago
|
||
Comment on attachment 611148 [details] [diff] [review]
(Av1) nsSuiteGlue.js: Fix typo ('ex', not 'err')
[Checked in: Comments 2 and 6]
http://hg.mozilla.org/releases/comm-aurora/rev/ee4776e4046b
http://hg.mozilla.org/releases/comm-beta/rev/32167786a4f1
Attachment #611148 -
Attachment description: (Av1) nsSuiteGlue.js: Fix typo ('ex', not 'err')
[Checked in: Comment 2] → (Av1) nsSuiteGlue.js: Fix typo ('ex', not 'err')
[Checked in: Comments 2 and 6]
Updated•13 years ago
|
Keywords: checkin-needed
Whiteboard: [c-n: 0fbde674fbb2 to c-a and c-b]
Updated•13 years ago
|
Attachment #611402 -
Flags: review?(kairo)
Attachment #611402 -
Flags: review+
Attachment #611402 -
Flags: approval-comm-beta?
Attachment #611402 -
Flags: approval-comm-beta+
Attachment #611402 -
Flags: approval-comm-aurora?
Attachment #611402 -
Flags: approval-comm-aurora+
Assignee | ||
Comment 7•13 years ago
|
||
Comment on attachment 611402 [details] [diff] [review]
(Bv1) nsSuiteGlue.js: Fix wrong object ('this', not 'importObserver')
[Checked in: Comments 7 and 9]
http://hg.mozilla.org/comm-central/rev/889c943bebeb
Attachment #611402 -
Attachment description: (Bv1) nsSuiteGlue.js: Fix wrong object ('this', not 'importObserver') → (Bv1) nsSuiteGlue.js: Fix wrong object ('this', not 'importObserver')
[Checked in: Comment 7]
Assignee | ||
Comment 8•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1333607321.1333611338.4439.gz&fulltext=1
WINNT 5.2 comm-central-trunk debug test mochitests-3/5 on 2012/04/04 23:28:41
V.Fixed wrt patch B too.
Comment 9•13 years ago
|
||
Comment on attachment 611402 [details] [diff] [review]
(Bv1) nsSuiteGlue.js: Fix wrong object ('this', not 'importObserver')
[Checked in: Comments 7 and 9]
http://hg.mozilla.org/releases/comm-aurora/rev/5ff32daa3b7e
http://hg.mozilla.org/releases/comm-beta/rev/62053a3b1aee
Attachment #611402 -
Attachment description: (Bv1) nsSuiteGlue.js: Fix wrong object ('this', not 'importObserver')
[Checked in: Comment 7] → (Bv1) nsSuiteGlue.js: Fix wrong object ('this', not 'importObserver')
[Checked in: Comments 7 and 9]
Updated•13 years ago
|
Keywords: checkin-needed
Whiteboard: [c-n: 889c943bebeb to c-a and c-b]
You need to log in
before you can comment on or make changes to this bug.
Description
•