Closed Bug 741068 Opened 12 years ago Closed 12 years ago

"err is not defined" at "nsSuiteGlue.js line: 752"

Categories

(SeaMonkey :: Bookmarks & History, defect, P3)

Product:
SeaMonkey
Component:
Bookmarks & History
Type:
defect

Tracking

(seamonkey2.8 wontfix, seamonkey2.9 fixed, seamonkey2.10 fixed)

Status:
VERIFIED FIXED
Milestone:
seamonkey2.11
Tracking Flags:
Tracking Status
seamonkey2.8 --- wontfix
seamonkey2.9 --- fixed
seamonkey2.10 --- fixed

People

(Reporter: sgautherie, Assigned: sgautherie)

References

(
URL
)

Details

Attachments

(2 files)

(Av1) nsSuiteGlue.js: Fix typo ('ex', not 'err') [Checked in: Comments 2 and 6]
1.24 KB, patch
Callek
: review+
philip.chee
: approval-comm-aurora+
philip.chee
: approval-comm-beta+
Details | Diff | Splinter Review
(Bv1) nsSuiteGlue.js: Fix wrong object ('this', not 'importObserver') [Checked in: Comments 7 and 9]
1.38 KB, patch
kairo
: review+
kairo
: approval-comm-aurora+
kairo
: approval-comm-beta+
Details | Diff | Splinter Review 
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1333157656.1333161682.31203.gz&fulltext=1
WINNT 5.2 comm-central-trunk debug test mochitests-3/5 on 2012/03/30 18:34:16
{
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "err is not defined" {file: "resource:///components/nsSuiteGlue.js" line: 752}]' when calling method: [nsIObserver::observe]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "<unknown>"  data: yes]
}
Flags: in-testsuite-
FF nsBrowserGlue.js uses 'err': you changed one but not the other.
Attachment #611148 - Flags: review?(kairo)
Attachment #611148 - Flags: review?(kairo) → review+
Comment on attachment 611148 [details] [diff] [review]
(Av1) nsSuiteGlue.js: Fix typo ('ex', not 'err')
[Checked in: Comments 2 and 6]

http://hg.mozilla.org/comm-central/rev/0fbde674fbb2


[Approval Request Comment]
As we hit this case on trunk, let's fix it on branches too, fwiw.
Attachment #611148 - Attachment description: (Av1) nsSuiteGlue.js: Fix typo ('ex', not 'err') → (Av1) nsSuiteGlue.js: Fix typo ('ex', not 'err') [Checked in: Comment 2]
Attachment #611148 - Flags: approval-comm-beta?
Attachment #611148 - Flags: approval-comm-aurora?
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment on attachment 611148 [details] [diff] [review]
(Av1) nsSuiteGlue.js: Fix typo ('ex', not 'err')
[Checked in: Comments 2 and 6]

Typo fix. a=me.
Attachment #611148 - Flags: approval-comm-beta?
Attachment #611148 - Flags: approval-comm-beta+
Attachment #611148 - Flags: approval-comm-aurora?
Attachment #611148 - Flags: approval-comm-aurora+
Keywords: checkin-needed
Whiteboard: [c-n: 0fbde674fbb2 to c-a and c-b]
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1333310123.1333313717.4786.gz&fulltext=1
WINNT 5.2 comm-central-trunk debug test mochitests-3/5 on 2012/04/01 12:55:23
{
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "importObserver is not defined" {file: "resource:///components/nsSuiteGlue.js" line: 753}]' when calling method: [nsIObserver::observe]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "<unknown>"  data: yes]
}

V.Fixed wrt patch A.
I don't know where these 'importObserver' came from: FF never had them.


[Approval Request Comment]
As we hit this case on trunk (probably because this code/feature is being removed from Toolkit), let's fix it on branches too, fwiw.
Attachment #611402 - Flags: review?(kairo)
Attachment #611402 - Flags: approval-comm-beta?
Attachment #611402 - Flags: approval-comm-aurora?
Comment on attachment 611148 [details] [diff] [review]
(Av1) nsSuiteGlue.js: Fix typo ('ex', not 'err')
[Checked in: Comments 2 and 6]

http://hg.mozilla.org/releases/comm-aurora/rev/ee4776e4046b
http://hg.mozilla.org/releases/comm-beta/rev/32167786a4f1
Attachment #611148 - Attachment description: (Av1) nsSuiteGlue.js: Fix typo ('ex', not 'err') [Checked in: Comment 2] → (Av1) nsSuiteGlue.js: Fix typo ('ex', not 'err') [Checked in: Comments 2 and 6]
status-seamonkey2.10: affected → fixed
status-seamonkey2.9: affected → fixed
Keywords: checkin-needed
Whiteboard: [c-n: 0fbde674fbb2 to c-a and c-b]
Attachment #611402 - Flags: review?(kairo)
Attachment #611402 - Flags: review+
Attachment #611402 - Flags: approval-comm-beta?
Attachment #611402 - Flags: approval-comm-beta+
Attachment #611402 - Flags: approval-comm-aurora?
Attachment #611402 - Flags: approval-comm-aurora+
Comment on attachment 611402 [details] [diff] [review]
(Bv1) nsSuiteGlue.js: Fix wrong object ('this', not 'importObserver')
[Checked in: Comments 7 and 9]

http://hg.mozilla.org/comm-central/rev/889c943bebeb
Attachment #611402 - Attachment description: (Bv1) nsSuiteGlue.js: Fix wrong object ('this', not 'importObserver') → (Bv1) nsSuiteGlue.js: Fix wrong object ('this', not 'importObserver') [Checked in: Comment 7]
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1333607321.1333611338.4439.gz&fulltext=1
WINNT 5.2 comm-central-trunk debug test mochitests-3/5 on 2012/04/04 23:28:41

V.Fixed wrt patch B too.
Status: RESOLVED → VERIFIED
Keywords: checkin-needed
Whiteboard: [c-n: 889c943bebeb to c-a and c-b]
Comment on attachment 611402 [details] [diff] [review]
(Bv1) nsSuiteGlue.js: Fix wrong object ('this', not 'importObserver')
[Checked in: Comments 7 and 9]

http://hg.mozilla.org/releases/comm-aurora/rev/5ff32daa3b7e
http://hg.mozilla.org/releases/comm-beta/rev/62053a3b1aee
Attachment #611402 - Attachment description: (Bv1) nsSuiteGlue.js: Fix wrong object ('this', not 'importObserver') [Checked in: Comment 7] → (Bv1) nsSuiteGlue.js: Fix wrong object ('this', not 'importObserver') [Checked in: Comments 7 and 9]
Keywords: checkin-needed
Whiteboard: [c-n: 889c943bebeb to c-a and c-b]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: