Closed Bug 741175 Opened 9 years ago Closed 9 years ago

Document skipping Places tests because the Private Browsing service is unavailable

Categories

(Toolkit :: Places, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: Paolo, Assigned: Paolo)

References

Details

Attachments

(2 files)

Per bug 728143 comment 21.
Attached patch The patchSplinter Review
Attachment #611258 - Flags: review?(mak77)
Comment on attachment 611258 [details] [diff] [review]
The patch

Review of attachment 611258 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/places/tests/favicons/test_setAndFetchFaviconForPage.js
@@ +53,5 @@
>  
>  add_test(function test_privateBrowsing_bookmarked()
>  {
>    if (!("@mozilla.org/privatebrowsing;1" in Cc)) {
> +    do_print("Private Browsing service is not available, bail out.");

Could you log which test function you're bailing out from?

::: toolkit/components/places/tests/unit/test_download_history.js
@@ +123,5 @@
>      }]
>    });
>  });
>  
> +add_test(function test_dh_addDownload_privateBrowsing()

Could you add a 'diff -w' to ease review?
Severity: normal → trivial
(In reply to Serge Gautherie (:sgautherie) from comment #2)
> > +    do_print("Private Browsing service is not available, bail out.");
> 
> Could you log which test function you're bailing out from?

This is reported in the preceding log line, I don't think it's worth repeating.

> Could you add a 'diff -w' to ease review?

Done!
Comment on attachment 611258 [details] [diff] [review]
The patch

one day we should merge do_log_info and do_print, even if I'm under the impression do_print when invoked from a head file prints the wrong filename, am I wrong?

Btw, in Places for now we use do_log_info and we should keep doing that until we merge the utils, imo (and also imo we should take do_log_info, cause do_print is too easy to confuse with the plain print() and not named after the mochitest info())
Attachment #611258 - Flags: review?(mak77) → review+
Pushed with the do_log_info call:

https://hg.mozilla.org/integration/mozilla-inbound/rev/6a4d396a3c43
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/6a4d396a3c43
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.