741175 - Document skipping Places tests because the Private Browsing service is unavailable

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[:Paolo Amadini]

Per bug 728143 comment 21.

Comment 1

[:Paolo Amadini]

Attachment: The patch

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 611258 [details] [diff] [review]
The patch

Review of attachment 611258 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/places/tests/favicons/test_setAndFetchFaviconForPage.js
@@ +53,5 @@
>  
>  add_test(function test_privateBrowsing_bookmarked()
>  {
>    if (!("@mozilla.org/privatebrowsing;1" in Cc)) {
> +    do_print("Private Browsing service is not available, bail out.");

Could you log which test function you're bailing out from?

::: toolkit/components/places/tests/unit/test_download_history.js
@@ +123,5 @@
>      }]
>    });
>  });
>  
> +add_test(function test_dh_addDownload_privateBrowsing()

Could you add a 'diff -w' to ease review?

Comment 3

[:Paolo Amadini]

Attachment: Whitespace changes ignored

(In reply to Serge Gautherie (:sgautherie) from comment #2)
> > +    do_print("Private Browsing service is not available, bail out.");
> 
> Could you log which test function you're bailing out from?

This is reported in the preceding log line, I don't think it's worth repeating.

> Could you add a 'diff -w' to ease review?

Done!

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 611258 [details] [diff] [review]
The patch

one day we should merge do_log_info and do_print, even if I'm under the impression do_print when invoked from a head file prints the wrong filename, am I wrong?

Btw, in Places for now we use do_log_info and we should keep doing that until we merge the utils, imo (and also imo we should take do_log_info, cause do_print is too easy to confuse with the plain print() and not named after the mochitest info())

Comment 5

[:Paolo Amadini]

Pushed with the do_log_info call:

https://hg.mozilla.org/integration/mozilla-inbound/rev/6a4d396a3c43

Comment 6

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/6a4d396a3c43