Closed
Bug 741263
Opened 13 years ago
Closed 13 years ago
Paris bindings constructors shouldn't abuse reserved identifiers.
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: emk, Assigned: peterv)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
21.70 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Identifiers beggining with _ + upercase letter are always reserved in C/C++.
|
||
Comment 1•13 years ago
|
||
Hmm. We need something that will never collide with WebIDL identifiers. Peter, any ideas? I guess we could make this CONSTRUCTOR all in caps?
_ + lowercase letter is not reserved, so we could just make these _constructor, _finalize, etc, right?
|
|
||
Comment 3•13 years ago
|
||
Oh, yes. That would work. Especially because we upcase all other WebIDL stuff.
|
Assignee | |
Comment 4•13 years ago
|
||
constructor is a reserved operation name in WebIDL, so I think we should use Constructor for the native function.
Assignee: nobody → peterv
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 5•13 years ago
|
||
Attachment #611449 -
Attachment is obsolete: true
Attachment #624846 -
Flags: review?(bzbarsky)
|
|
||
Comment 6•13 years ago
|
||
Comment on attachment 624846 [details] [diff] [review]
v1
r=me
Attachment #624846 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 7•13 years ago
|
||
|
|
Assignee | |
Updated•13 years ago
|
Target Milestone: --- → mozilla15
|
|
||
Comment 8•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•