The default bug view has changed. See this FAQ.

Paris bindings constructors shouldn't abuse reserved identifiers.

RESOLVED FIXED in mozilla15

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: emk, Assigned: peterv)

Tracking

Trunk
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Identifiers beggining with _ + upercase letter are always reserved in C/C++.
Hmm.  We need something that will never collide with WebIDL identifiers.  Peter, any ideas?  I guess we could make this CONSTRUCTOR all in caps?
_ + lowercase letter is not reserved, so we could just make these _constructor, _finalize, etc, right?
Oh, yes.  That would work.  Especially because we upcase all other WebIDL stuff.
(Assignee)

Comment 4

5 years ago
Created attachment 611449 [details] [diff] [review]
v1

constructor is a reserved operation name in WebIDL, so I think we should use Constructor for the native function.
Assignee: nobody → peterv
Status: NEW → ASSIGNED
(Assignee)

Comment 5

5 years ago
Created attachment 624846 [details] [diff] [review]
v1
Attachment #611449 - Attachment is obsolete: true
Attachment #624846 - Flags: review?(bzbarsky)
Comment on attachment 624846 [details] [diff] [review]
v1

r=me
Attachment #624846 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/34c1f88c3e7d
(Assignee)

Updated

5 years ago
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/34c1f88c3e7d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.