Add back support for making a thumbnail after pageload

VERIFIED FIXED in Firefox 15

Status

()

Firefox for Android
General
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: mfinkle, Assigned: gbrown)

Tracking

unspecified
Firefox 14
x86
Android
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox15 verified, blocking-fennec1.0 beta+)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Bug 740146 removed the screenshot code, but also removed making a thumbnail after a pageload. We should add that back:

https://hg.mozilla.org/integration/mozilla-inbound/rev/d3f20d0371d0#l1.180

Right now, we only make thumbnails when opening the TabTray. About:Home also depends on thumbnails and might be empty until the TabTray is displayed.
(Assignee)

Comment 1

6 years ago
Darn, how did that happen? Purely unintentional...
(Assignee)

Updated

6 years ago
Assignee: nobody → gbrown
(Assignee)

Updated

6 years ago
Depends on: 740146
OS: Linux → Android
(Assignee)

Comment 2

6 years ago
Created attachment 611498 [details] [diff] [review]
add back thumbnail creation on page load

I think it's as simple as calling getAndProcessThumbnailForTab - it seems to work for me - and that the remainder of the old SessionSnapshotRunnable is no longer relevant.
Attachment #611498 - Flags: review?(mark.finkle)
Comment on attachment 611498 [details] [diff] [review]
add back thumbnail creation on page load


>+        if (Tabs.getInstance().isSelectedTab(tab)) {
>+            GeckoAppShell.getHandler().postDelayed(new Runnable() {
>+                public void run() {
>+                    getAndProcessThumbnailForTab(tab);
>+                }
>+            }, 500);
>+        }

Just remove the isSelected check. I'm pretty sure we want to always make the thumbnail on a pageload.
Attachment #611498 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 4

6 years ago
Created attachment 611535 [details] [diff] [review]
add back thumbnail creation on page load

Removed check for selected tab and re-tested. r=mfinkle carried.
Attachment #611498 - Attachment is obsolete: true
Attachment #611535 - Flags: review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
Needed for proper thumbnail creation
blocking-fennec1.0: --- → beta+
https://hg.mozilla.org/integration/mozilla-inbound/rev/553c1d8965ca
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → Firefox 14
https://hg.mozilla.org/mozilla-central/rev/553c1d8965ca
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Thumbnail is created after pageload on the latest Nightly. Closing bug as verified fixed on:

Firefox 15.0a1 (2012-05-22)
Device: Galaxy Nexus
OS: Android 4.0.2
Status: RESOLVED → VERIFIED
status-firefox15: --- → verified
You need to log in before you can comment on or make changes to this bug.