Sydneyaudio does not include MOZ_ALSA_CFLAGS

RESOLVED FIXED in mozilla14

Status

()

Core
Audio/Video
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: prabindh, Assigned: prabindh)

Tracking

Trunk
mozilla14
ARM
Linux
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 611374 [details]
3 patches for config.in, autoconf.mk.in, and Makefile.in

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:10.0.1) Gecko/20100101 Firefox/10.0.1
Build ID: 20120209214325

Steps to reproduce:

Crosscompiled Mozilla embedded for ARM.


Actual results:

Error: alsa/asoundlib.h not found, coming from sydneyaudio/src compilation.


Expected results:

MOZ_ALSA_CFLAGS should be a dependency in libsydneyaudio make, as it is a dependent component. However, current autoconf.mk, as well as config.in, only "check" for ALSA, but do not pass it on. Hence if <CROSSCOMPILEROOT>/usr/include is not in the CFLAGS path, libsydneyaudio make fails. Most times we typically add <CROSSCOMPILEROOT>/usr/include globally to CFLAGS and hence this goes unnoticed. Attached patchset to fix this.
(Assignee)

Updated

5 years ago
Hardware: x86 → ARM
(Assignee)

Comment 1

5 years ago
Created attachment 611512 [details] [diff] [review]
Unified patch for changes to enable passing of MOZ_ALSA_CFLAGS

Added :glandium" or ":ted" per inputs from :romaxa
Attachment #611374 - Attachment is obsolete: true
Attachment #611512 - Flags: review?(ted.mielczarek)
Attachment #611512 - Flags: review?(romaxa)
Attachment #611512 - Flags: review?(mh+mozilla)
Comment on attachment 611512 [details] [diff] [review]
Unified patch for changes to enable passing of MOZ_ALSA_CFLAGS

One more thing,
In order to simplify patch integration, it is better to generate patch with hg export, or hg diff, also use -p -U 8
And add to header Bug number and description.
See for example https://bug738865.bugzilla.mozilla.org/attachment.cgi?id=609019
Attachment #611512 - Flags: review?(romaxa)
(Assignee)

Comment 3

5 years ago
Created attachment 611759 [details] [diff] [review]
hg patch updated per romaxa's comments

In order to simplify patch integration, generated patch with hg diff, also used -p -U 8
And added to header Bug number and description.
Attachment #611512 - Attachment is obsolete: true
Attachment #611512 - Flags: review?(ted.mielczarek)
Attachment #611512 - Flags: review?(mh+mozilla)
Attachment #611759 - Flags: review?(romaxa)
Comment on attachment 611759 [details] [diff] [review]
hg patch updated per romaxa's comments

Review of attachment 611759 [details] [diff] [review]:
-----------------------------------------------------------------

> MOZ_ENABLE_LIBNOTIFY	= @MOZ_ENABLE_LIBNOTIFY@
> 
> MOZ_ALSA_LIBS           = @MOZ_ALSA_LIBS@
>+MOZ_ALSA_CFLAGS           = @MOZ_ALSA_CFLAGS@

Make this line indented with line above pls

Also I'm not able to review configure part, see https://wiki.mozilla.org/Modules/Activities#Module_Ownership_System
Ask review from glandium OR ted,  both are not needed for this patch
Attachment #611759 - Flags: review?(romaxa)
(Assignee)

Comment 5

5 years ago
Created attachment 611788 [details] [diff] [review]
alignment to assignment line and cleanup for patch submission
Attachment #611759 - Attachment is obsolete: true
Attachment #611788 - Flags: review?(romaxa)
Attachment #611788 - Flags: review?(mh+mozilla)
Attachment #611788 - Flags: review?(romaxa) → feedback+
Attachment #611788 - Flags: review?(mh+mozilla) → review+
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Keywords: checkin-needed

Updated

5 years ago
Assignee: nobody → prabu
Version: 2.0 Branch → Trunk
https://hg.mozilla.org/integration/mozilla-inbound/rev/810e8295b080
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/810e8295b080
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.