741293 - argument to :dir() and :-moz-locale-dir() is treated case-sensitively; should be case-insensitive

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[John Daggett (:jtd)]

The code in CSSParserImpl::ParsePseudoClassWithIdentArg contains:

  // -moz-locale-dir can only have values of 'ltr' or 'rtl'.
  if (aType == nsCSSPseudoClasses::ePseudoClass_mozLocaleDir) {
    if (!mToken.mIdent.EqualsLiteral("ltr") &&
        !mToken.mIdent.EqualsLiteral("rtl")) {
      return eSelectorParsingStatus_Error; // our caller calls SkipUntil(')')
    }
  }

http://mxr.mozilla.org/mozilla-central/source/layout/style/nsCSSParser.cpp#3419

Those comparisons need to be case-insensitive.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Yep, should be LowerCaseEqualsLiteral.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 611465 [details] [diff] [review]
patch

Er, wait, that's not quite sufficient; need to lowercase what we store too.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(If someone else wants to finish this that's fine with me.)

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This is higher priority now that bug 562169 landed.  We need to get it in the same release as bug 562169.  Patch coming, once I make sure the tests pass.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Treat argument of :-moz-locale-dir() case-insensitively. ()

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d086edab3616

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d086edab3616