Closed Bug 741301 Opened 13 years ago Closed 12 years ago

Disable broken l10n crop tests until false positives have been resolved

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Product:
Mozilla QA Graveyard
Component:
Mozmill Tests
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox22 fixed, firefox23 fixed, firefox24 fixed, firefox25 fixed, firefox-esr10 wontfix, firefox-esr17 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox22 --- fixed
firefox23 --- fixed
firefox24 --- fixed
firefox25 --- fixed
firefox-esr10 --- wontfix
firefox-esr17 --- fixed

People

(Reporter: whimboo, Assigned: andrei)

References

Details

(Whiteboard: [mozmill-l10n])

Attachments

(4 files)

Patch v1 [landed]
753 bytes, patch
davehunt
: review+
Details | Diff | Splinter Review
unskip - nightly, aurora
1.15 KB, patch
AndreeaMatei
: review+
Details | Diff | Splinter Review
unskip - beta, release
1.22 KB, patch
AndreeaMatei
: review+
Details | Diff | Splinter Review
unskip - esr17
1.13 KB, patch
AndreeaMatei
: review+
Details | Diff | Splinter Review
As long as this test is not working properly we have to disable it.
It's mostly because of bug 614579 that we are failing, but there can also be other instances.
Blocks: 614579
Whiteboard: [mozmill-l10n]
Attachment #611398 - Flags: review?(dave.hunt)
Attachment #611398 - Flags: review?(dave.hunt) → review+
Attachment #611398 - Attachment description: Patch v1 → Patch v1 [landed]
Whiteboard: [mozmill-l10n] → [mozmill-l10n][mozmill-test-skipped]
This should not have been closed. Reopening, so we can get it landed once bug 741762 is fixed.
Status: RESOLVED → REOPENED
Depends on: 741762
Resolution: FIXED → ---
Backed-out across branches: http://hg.mozilla.org/qa/mozmill-tests/rev/bb258f3d26b0 (default) http://hg.mozilla.org/qa/mozmill-tests/rev/0f2d675e5f19 (aurora) http://hg.mozilla.org/qa/mozmill-tests/rev/e511a2f442ae (beta) http://hg.mozilla.org/qa/mozmill-tests/rev/747c5b6d8ea1 (release) http://hg.mozilla.org/qa/mozmill-tests/rev/985b35c3bc54 (esr10)
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
status-firefox-esr10: --- → fixed
status-firefox13: --- → fixed
status-firefox14: --- → fixed
status-firefox15: --- → fixed
status-firefox16: --- → fixed
Resolution: --- → FIXED
Whiteboard: [mozmill-l10n][mozmill-test-skipped] → [mozmill-l10n]
I had to re-land this patch to skip the crop tests. Right now we have too many false positives and I'm inclined not to enable those tests again until we have solved all of them. Please file dependent bugs so we can get those tracked. Pushed: http://hg.mozilla.org/qa/mozmill-tests/rev/c47167154d35 http://hg.mozilla.org/qa/mozmill-tests/rev/986c74f95b91 http://hg.mozilla.org/qa/mozmill-tests/rev/dbec55005135 http://hg.mozilla.org/qa/mozmill-tests/rev/b3de6a4b835d http://hg.mozilla.org/qa/mozmill-tests/rev/8d43b51bf2d7
Status: RESOLVED → REOPENED
status-firefox-esr10: fixed → affected
status-firefox13: fixed → affected
status-firefox14: fixed → affected
status-firefox15: fixed → affected
status-firefox16: fixed → affected
Resolution: FIXED → ---
Summary: Disable broken l10n tests for cropped elements → Disable broken l10n crop tests until false positives have been resolved
Whiteboard: [mozmill-l10n] → [mozmill-l10n][mozmill-test-skipped]
Depends on: 763470
Assignee: hskupin → nobody
Status: REOPENED → NEW
No longer blocks: 614579
Depends on: 614579
Blocks: 562084
Depends on: 763638
A minor note; as a result of landed bug 873473, the bug referenced in the skip for this bug has been updated to this bugnumber (741301).
Attachment #776406 - Flags: review?(andreea.matei)
Attachment #776407 - Flags: review?(andreea.matei)
Attached patch unskip - esr17 — — Splinter Review
No failures across all branches and OS's Had to make a different patch for Beta/Release and ESR17 (very minor changes eg. spacing) Let's land this and if no errors on CI, we can close all dependencies. Some reports: OSX --- Nightly: http://mozmill-crowd.blargon7.com/#/l10n/report/5aa1ca5e7015e3740d269dc9477b714b Aurora: http://mozmill-crowd.blargon7.com/#/l10n/report/5aa1ca5e7015e3740d269dc9477b9322 Beta: http://mozmill-crowd.blargon7.com/#/l10n/report/5aa1ca5e7015e3740d269dc9477c0fa0 Release: http://mozmill-crowd.blargon7.com/#/l10n/report/5aa1ca5e7015e3740d269dc9477c5775 ESR17: http://mozmill-crowd.blargon7.com/#/l10n/report/5aa1ca5e7015e3740d269dc9477cc951 Linux ----- Nightly: http://mozmill-crowd.blargon7.com/#/l10n/report/5aa1ca5e7015e3740d269dc9477e51c3 Aurora: http://mozmill-crowd.blargon7.com/#/l10n/report/5aa1ca5e7015e3740d269dc9477e9ee8 Beta: http://mozmill-crowd.blargon7.com/#/l10n/report/5aa1ca5e7015e3740d269dc9477ed4f8 Release: http://mozmill-crowd.blargon7.com/#/l10n/report/5aa1ca5e7015e3740d269dc9477f2c5f ESR17: http://mozmill-crowd.blargon7.com/#/l10n/report/5aa1ca5e7015e3740d269dc9477f5f8b Windows ------- Nightly: http://mozmill-crowd.blargon7.com/#/l10n/report/5aa1ca5e7015e3740d269dc947824294 Aurora: http://mozmill-crowd.blargon7.com/#/l10n/report/5aa1ca5e7015e3740d269dc9478284f2 Beta: http://mozmill-crowd.blargon7.com/#/l10n/report/5aa1ca5e7015e3740d269dc947836b02 Release: http://mozmill-crowd.blargon7.com/#/l10n/report/5aa1ca5e7015e3740d269dc94783ba05 ESR17: http://mozmill-crowd.blargon7.com/#/l10n/report/5aa1ca5e7015e3740d269dc94783d55f
Attachment #776408 - Flags: review?(andreea.matei)
Comment on attachment 776406 [details] [diff] [review] unskip - nightly, aurora Review of attachment 776406 [details] [diff] [review]: ----------------------------------------------------------------- Re-enabled: http://hg.mozilla.org/qa/mozmill-tests/rev/ee401c7796a6 (default) http://hg.mozilla.org/qa/mozmill-tests/rev/f8783208f5d1 (aurora)
Attachment #776406 - Flags: review?(andreea.matei) → review+
Comment on attachment 776407 [details] [diff] [review] unskip - beta, release Review of attachment 776407 [details] [diff] [review]: ----------------------------------------------------------------- http://hg.mozilla.org/qa/mozmill-tests/rev/2f91220a3207 (beta) http://hg.mozilla.org/qa/mozmill-tests/rev/1d70a0cbf8d3 (release) http://hg.mozilla.org/qa/mozmill-tests/rev/d5e646d69443 (esr17)
Attachment #776407 - Flags: review?(andreea.matei) → review+
Attachment #776408 - Flags: review?(andreea.matei) → review+
Assignee: nobody → andrei.eftimie
Status: NEW → RESOLVED
Closed: 13 years ago → 12 years ago
status-firefox18: affected → ---
status-firefox19: affected → ---
status-firefox20: affected → ---
status-firefox21: affected → ---
status-firefox22: --- → fixed
status-firefox23: --- → fixed
status-firefox24: --- → fixed
status-firefox25: --- → fixed
status-firefox-esr17: --- → fixed
Depends on: 763461
Resolution: --- → FIXED
Whiteboard: [mozmill-l10n][mozmill-test-skipped] → [mozmill-l10n]
Wonderful news. Thanks so much Andrei for working on this! That's a big step forward.
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: