74132 - Help needs build/installer

Status: VERIFIED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Ian Oeschger (gone)]

Need to get Mozilla help build and install working, get it reviewed, and get it
checked in.

Comment 1

[Ian Oeschger (gone)]

Attachment: Graahh! I am having trouble getting the windows build stuff to work. Here is my unhandiwork.

Comment 2

[Ian Oeschger (gone)]

I see one problem. In my makefile.win, I was doing this:
chrome::
	$(REGCHROME) content content/help help.jar
	$(REGCHROME) skin modern/help help.jar
	$(REGCHROME) locale en-US/help help.jar
which appended an extra content/content/help to the installed-chrome.txt file.
makefile.win in extensions/help/resources now says:
chrome::
	$(REGCHROME) content help help.jar
	$(REGCHROME) skin modern/help help.jar
	$(REGCHROME) locale en-US/help help.jar

Comment 3

[rudman]

Adding dveditz and ssu to cc list.

Ian, I talked to Sean about the Windows issues---I think he can help out. Touch 
base with him on Monday.

Comment 4

[Ian Oeschger (gone)]

Attachment: jar.mn for all help files

Comment 5

[Ian Oeschger (gone)]

Attachment: makefile at mozilla/extensions/help/makefile.win

Comment 6

[Ian Oeschger (gone)]

Attachment: makefile.win at mozilla/extensions/help/resources

Comment 7

[Ian Oeschger (gone)]

Attachment: redo: _this_ is the makefile.win at extensions\help

Comment 8

[Ian Oeschger (gone)]

Attachment: redo: and _THIS_ is the makefile.win at extensions/help/resources, which registers the chrome

Comment 9

[Ian Oeschger (gone)]

I have the help building on windows now (with the files attached above). Sean, I
wonder if you would mind taking the attached files (jar.mn is meant for
mozilla/extensions/help/resources/, and the makefile.win locations are in the
attachment notes), adding...heck, let me create a new down-low diff
(mozilla/xpinstall et al) and attach it here. Then the windows build files will
be that new patch, plus the jar.mn, makefile.win, and resources/makefile.win
files attached here. Hold on a sec...

Sean and/or Samir: I was going to say: can you take this stuff and verify that
it builds the help on win32? Samir and I have it building on linux, and I think
he is going to get some information about the mac build shortly, which he worked
out.

Thanks a lot. Patch coming in a second.

Comment 10

[Samir Gehani]

Attachment: Mac build system modification to build the new help extension.

Comment 11

[Ian Oeschger (gone)]

Attachment: testing diff for whole help build

Comment 12

[Ian Oeschger (gone)]

How does the foregoing superpatch look? I have some extra chrome-related diffs
in there that I haven't been able to check in yet (and which I _will_ check in
this afternoon, so the patch is just build stuff), but I think the rest of it
(xpinstall/packager configure.in configure allmakefile.sh build/mac
extensions/makefile.win extensions/help) has got it. Samir & Sean, if you guys
have a moment, can we see if this patch gets the help building? Again, thanks _a
lot_.

Comment 13

[Samir Gehani]

Attachment: Add help.jar to packages-mac as well.

Comment 14

[Samir Gehani]

Please add help.jar (see my last patch (id=29859)) and also register help chrome
in the mac browser.jst and repost the patch.  Thanks.

Comment 15

[Ian Oeschger (gone)]

Attachment: I think this is the real thing. checked in the chrome updates to get rid of them, too

Comment 16

[Samir Gehani]

Last patch (id=29868) looks good to me so r=sgehani.  However, if you want
help.jar to be registered by the commercial installers (so help shows up in
Netscape 6) as well please modify the mac, unix, and windows browser.jsts in the
ns tree as well.  They can be found at:
ns/xpinstall/packager/mac/browser.jst
ns/xpinstall/packager/unix/browser.jst
ns/xpinstall/packager/windows/browser.jst

Comment 17

[Ian Oeschger (gone)]

Going to defer the ns packaging setup a little while and make sure we have
everything taken care of in the mozilla world first. In addition to the
commercial packaging, we will also need to maintain the commercial help content
separatel, for which I will create a new bug.

Comment 18

[Ian Oeschger (gone)]

cls and/or alecf
Do you guys think you could take a look at the build piece for the Mozilla Help
viewer in the "superpatch" attached here and sr if you think it looks good. We
have built on mac, windows, and linux successfully. I'd like to get a couple
more r's (r=jag, r=dveditz?), but I think we are ready to go here.

Thanks _a lot_.
ian

Note: the help chrome itself has already been reviewed. I decided, perhaps
overcautiously, to try and get separate reviews for the chrome and for building
the chrome

Comment 19

[Sean Su]

r=ssu for the part of the patch that affects the windows platform.

Comment 20

[Alec Flett]

cool! sr=alecf on the latest patch. Great to see this landing.

Comment 21

[lchiang]

wonderful work by everyone!

Comment 22

[cls]

The unix & win build changes look fine except that you need to add
extensions/help/Makefile to allmakefiles.sh as well.  r=cls

Comment 23

[Ian Oeschger (gone)]

cls
I saw the 
MAKEFILES_extensions="
extensions/Makefile
"
line in allmakefiles.sh and assumed that would pick mine up (since that Makefile's DIRS uses $MOZ_EXTENSIONS, itself defined in allmakefiles.sh). Where should I add this? Right next to the extensions/Makefile? Thanks.

Comment 24

[cls]

MAKEFILES_extensions will pick up your changes but you still missed a Makefile
in the case switch.  You need to add 'extensions/help/Makefile' to this switch:

+       help ) MAKEFILES_extensions="$MAKEFILES_extensions
+           extensions/help/resources/Makefile
+           " ;;
+

Comment 25

[Ian Oeschger (gone)]

Attachment: missed a Makefile in allmakefiles.sh; patch for it here

Comment 26

[cls]

r=cls on attach 30835

Comment 27

[David Hallowell]

*** Bug 76471 has been marked as a duplicate of this bug. ***

Comment 28

[Ian Oeschger (gone)]

Got the installer working thanks to Sean Su and Samir. Marking FIXED

Comment 29

[Brant Gurganus]

v