Remove PRBool/PR_TRUE/PR_FALSE that crept in

RESOLVED FIXED in mozilla14

Status

()

Core
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Veeraya Pupatwibul)

Tracking

Trunk
mozilla14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=Ms2ger][lang=c++])

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

5 years ago
All the instances listed here:

http://mxr.mozilla.org/mozilla-central/ident?i=PRBool&tree=mozilla-central&filter=.cpp
http://mxr.mozilla.org/mozilla-central/ident?i=PR_FALSE&tree=mozilla-central&filter=.cpp
http://mxr.mozilla.org/mozilla-central/ident?i=PR_TRUE&tree=mozilla-central&filter=.cpp

should be replaced with bool / false / true, except for those under nsprpub/.
(Assignee)

Comment 1

5 years ago
can i be assigned to this bug please?
(Reporter)

Comment 2

5 years ago
Certainly. Let me know if you need any help.
Assignee: nobody → pookveeraya
(Assignee)

Comment 3

5 years ago
Created attachment 611454 [details] [diff] [review]
first patch
Attachment #611454 - Flags: review?(Ms2ger)
(Reporter)

Comment 4

5 years ago
Comment on attachment 611454 [details] [diff] [review]
first patch

Review of attachment 611454 [details] [diff] [review]:
-----------------------------------------------------------------

It looks like you replaced all PR_TRUEs with false instead of true, could you fix that?

::: dom/base/DOMRequest.cpp
@@ +130,5 @@
>    if (NS_FAILED(rv)) {
>      return;
>    }
>  
> +  rv = event->SetTrusted(false);

Er, I think this should be 'true'

::: dom/network/src/Connection.cpp
@@ +137,5 @@
>    nsRefPtr<nsDOMEvent> event = new nsDOMEvent(nsnull, nsnull);
>    nsresult rv = event->InitEvent(aEventName, false, false);
>    NS_ENSURE_SUCCESS(rv, rv);
>  
> +  rv = event->SetTrusted(false);

Same here

::: dom/sms/src/SmsRequestManager.cpp
@@ +113,5 @@
>    nsRefPtr<nsDOMEvent> event = new nsDOMEvent(nsnull, nsnull);
>    nsresult rv = event->InitEvent(aEventName, false, false);
>    NS_ENSURE_SUCCESS(rv, rv);
>  
> +  rv = event->SetTrusted(false);

here
Attachment #611454 - Flags: review?(Ms2ger)
(Assignee)

Comment 5

5 years ago
Created attachment 611457 [details] [diff] [review]
PR_TRUE is now 'true'

Hope it's correct this time:)
Attachment #611454 - Attachment is obsolete: true
Attachment #611457 - Flags: review?(Ms2ger)
(Reporter)

Comment 6

5 years ago
Comment on attachment 611457 [details] [diff] [review]
PR_TRUE is now 'true'

Review of attachment 611457 [details] [diff] [review]:
-----------------------------------------------------------------

Hrm, I'm not sure the changes in security/manager/ssl/src/ and testing/mochitest/ssltunnel/ssltunnel.cpp are good… Could you leave those as they are?

Looks good otherwise.

::: toolkit/xre/nsAppRunner.cpp
@@ +2633,5 @@
>   *
>   * By defining the symbol here, we can avoid the wasted lookup and hopefully
>   * improve startup performance.
>   */
> +NS_VISIBILITY_DEFAULT bool nspr_use_zone_allocator = false;

I think you need to leave this one alone.
Attachment #611457 - Flags: review?(Ms2ger) → review+
(Assignee)

Comment 7

5 years ago
Created attachment 611476 [details] [diff] [review]
removed changes for security/manager/ssl/src/, testing/mochitest/ssltunnel/ssltunnel.cpp and toolkit/xre/nsAppRunner.cpp
Attachment #611457 - Attachment is obsolete: true
Attachment #611476 - Flags: review?(Ms2ger)
(Reporter)

Comment 8

5 years ago
Comment on attachment 611476 [details] [diff] [review]
removed changes for security/manager/ssl/src/, testing/mochitest/ssltunnel/ssltunnel.cpp and toolkit/xre/nsAppRunner.cpp

Review of attachment 611476 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!
Attachment #611476 - Flags: review?(Ms2ger) → review+
(Reporter)

Updated

5 years ago
Whiteboard: [good first bug][mentor=Ms2ger][lang=c++] → [good first bug][mentor=Ms2ger][lang=c++][autoland-try]

Updated

5 years ago
Whiteboard: [good first bug][mentor=Ms2ger][lang=c++][autoland-try] → [good first bug][mentor=Ms2ger][lang=c++][autoland-in-queue]

Comment 9

5 years ago
Autoland Patchset:
	Patches: 611476
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=1b39bb4588fc
Try run started, revision 1b39bb4588fc. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=1b39bb4588fc

Comment 10

5 years ago
Try run for 1b39bb4588fc is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=1b39bb4588fc
Results (out of 15 total builds):
    success: 11
    failure: 4
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-1b39bb4588fc

Updated

5 years ago
Whiteboard: [good first bug][mentor=Ms2ger][lang=c++][autoland-in-queue] → [good first bug][mentor=Ms2ger][lang=c++]
(Reporter)

Comment 11

5 years ago
Looks like I left out the headers in my links... Could you also change:

MayHaveDOMMutationObservers() in content/base/public/nsIDocument.h
ShouldSkipSpellCheck() in editor/libeditor/base/nsEditor.h
IsBasicLatinLetterOrNumeral() in widget/gtk2/nsGtkKeyUtils.h
mStreamInitialized, mStreamEnded, and mStreamInitialized again in netwerk/cache/nsCacheEntryDescriptor.h

Sorry about that.
(Assignee)

Comment 12

5 years ago
Created attachment 611879 [details] [diff] [review]
lastest patch with changes in header files
Attachment #611476 - Attachment is obsolete: true
Attachment #611879 - Flags: review?(Ms2ger)
(Reporter)

Comment 13

5 years ago
Comment on attachment 611879 [details] [diff] [review]
lastest patch with changes in header files

Review of attachment 611879 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!
Attachment #611879 - Flags: review?(Ms2ger) → review+
(Reporter)

Updated

5 years ago
Whiteboard: [good first bug][mentor=Ms2ger][lang=c++] → [good first bug][mentor=Ms2ger][lang=c++][autoland-try]

Updated

5 years ago
Whiteboard: [good first bug][mentor=Ms2ger][lang=c++][autoland-try] → [good first bug][mentor=Ms2ger][lang=c++][autoland-in-queue]

Comment 14

5 years ago
Autoland Patchset:
	Patches: 611879
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=d1fe05316552
Try run started, revision d1fe05316552. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=d1fe05316552

Comment 15

5 years ago
Try run for d1fe05316552 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=d1fe05316552
Results (out of 15 total builds):
    success: 15
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-d1fe05316552

Updated

5 years ago
Whiteboard: [good first bug][mentor=Ms2ger][lang=c++][autoland-in-queue] → [good first bug][mentor=Ms2ger][lang=c++]
(Reporter)

Updated

5 years ago
Keywords: checkin-needed

Comment 16

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/523d5c5c53eb
Target Milestone: --- → mozilla14
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/523d5c5c53eb
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.