Last Comment Bug 741333 - Remove PRBool/PR_TRUE/PR_FALSE that crept in
: Remove PRBool/PR_TRUE/PR_FALSE that crept in
Status: RESOLVED FIXED
[good first bug][mentor=Ms2ger][lang=...
:
Product: Core
Classification: Components
Component: General (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla14
Assigned To: Veeraya Pupatwibul
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-02 03:20 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2012-04-05 10:46 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
first patch (35.39 KB, patch)
2012-04-02 07:35 PDT, Veeraya Pupatwibul
no flags Details | Diff | Splinter Review
PR_TRUE is now 'true' (35.37 KB, patch)
2012-04-02 07:53 PDT, Veeraya Pupatwibul
Ms2ger: review+
Details | Diff | Splinter Review
removed changes for security/manager/ssl/src/, testing/mochitest/ssltunnel/ssltunnel.cpp and toolkit/xre/nsAppRunner.cpp (26.20 KB, patch)
2012-04-02 09:07 PDT, Veeraya Pupatwibul
Ms2ger: review+
Details | Diff | Splinter Review
lastest patch with changes in header files (30.90 KB, patch)
2012-04-03 10:35 PDT, Veeraya Pupatwibul
Ms2ger: review+
Details | Diff | Splinter Review

Comment 1 Veeraya Pupatwibul 2012-04-02 04:44:49 PDT
can i be assigned to this bug please?
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2012-04-02 04:47:29 PDT
Certainly. Let me know if you need any help.
Comment 3 Veeraya Pupatwibul 2012-04-02 07:35:57 PDT
Created attachment 611454 [details] [diff] [review]
first patch
Comment 4 :Ms2ger (⌚ UTC+1/+2) 2012-04-02 07:38:47 PDT
Comment on attachment 611454 [details] [diff] [review]
first patch

Review of attachment 611454 [details] [diff] [review]:
-----------------------------------------------------------------

It looks like you replaced all PR_TRUEs with false instead of true, could you fix that?

::: dom/base/DOMRequest.cpp
@@ +130,5 @@
>    if (NS_FAILED(rv)) {
>      return;
>    }
>  
> +  rv = event->SetTrusted(false);

Er, I think this should be 'true'

::: dom/network/src/Connection.cpp
@@ +137,5 @@
>    nsRefPtr<nsDOMEvent> event = new nsDOMEvent(nsnull, nsnull);
>    nsresult rv = event->InitEvent(aEventName, false, false);
>    NS_ENSURE_SUCCESS(rv, rv);
>  
> +  rv = event->SetTrusted(false);

Same here

::: dom/sms/src/SmsRequestManager.cpp
@@ +113,5 @@
>    nsRefPtr<nsDOMEvent> event = new nsDOMEvent(nsnull, nsnull);
>    nsresult rv = event->InitEvent(aEventName, false, false);
>    NS_ENSURE_SUCCESS(rv, rv);
>  
> +  rv = event->SetTrusted(false);

here
Comment 5 Veeraya Pupatwibul 2012-04-02 07:53:43 PDT
Created attachment 611457 [details] [diff] [review]
PR_TRUE is now 'true'

Hope it's correct this time:)
Comment 6 :Ms2ger (⌚ UTC+1/+2) 2012-04-02 08:32:41 PDT
Comment on attachment 611457 [details] [diff] [review]
PR_TRUE is now 'true'

Review of attachment 611457 [details] [diff] [review]:
-----------------------------------------------------------------

Hrm, I'm not sure the changes in security/manager/ssl/src/ and testing/mochitest/ssltunnel/ssltunnel.cpp are good… Could you leave those as they are?

Looks good otherwise.

::: toolkit/xre/nsAppRunner.cpp
@@ +2633,5 @@
>   *
>   * By defining the symbol here, we can avoid the wasted lookup and hopefully
>   * improve startup performance.
>   */
> +NS_VISIBILITY_DEFAULT bool nspr_use_zone_allocator = false;

I think you need to leave this one alone.
Comment 7 Veeraya Pupatwibul 2012-04-02 09:07:22 PDT
Created attachment 611476 [details] [diff] [review]
removed changes for security/manager/ssl/src/, testing/mochitest/ssltunnel/ssltunnel.cpp and toolkit/xre/nsAppRunner.cpp
Comment 8 :Ms2ger (⌚ UTC+1/+2) 2012-04-02 09:19:01 PDT
Comment on attachment 611476 [details] [diff] [review]
removed changes for security/manager/ssl/src/, testing/mochitest/ssltunnel/ssltunnel.cpp and toolkit/xre/nsAppRunner.cpp

Review of attachment 611476 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!
Comment 9 Mozilla RelEng Bot 2012-04-02 09:22:38 PDT
Autoland Patchset:
	Patches: 611476
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=1b39bb4588fc
Try run started, revision 1b39bb4588fc. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=1b39bb4588fc
Comment 10 Mozilla RelEng Bot 2012-04-02 13:32:33 PDT
Try run for 1b39bb4588fc is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=1b39bb4588fc
Results (out of 15 total builds):
    success: 11
    failure: 4
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-1b39bb4588fc
Comment 11 :Ms2ger (⌚ UTC+1/+2) 2012-04-02 14:17:49 PDT
Looks like I left out the headers in my links... Could you also change:

MayHaveDOMMutationObservers() in content/base/public/nsIDocument.h
ShouldSkipSpellCheck() in editor/libeditor/base/nsEditor.h
IsBasicLatinLetterOrNumeral() in widget/gtk2/nsGtkKeyUtils.h
mStreamInitialized, mStreamEnded, and mStreamInitialized again in netwerk/cache/nsCacheEntryDescriptor.h

Sorry about that.
Comment 12 Veeraya Pupatwibul 2012-04-03 10:35:17 PDT
Created attachment 611879 [details] [diff] [review]
lastest patch with changes in header files
Comment 13 :Ms2ger (⌚ UTC+1/+2) 2012-04-03 10:47:43 PDT
Comment on attachment 611879 [details] [diff] [review]
lastest patch with changes in header files

Review of attachment 611879 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!
Comment 14 Mozilla RelEng Bot 2012-04-03 10:51:37 PDT
Autoland Patchset:
	Patches: 611879
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=d1fe05316552
Try run started, revision d1fe05316552. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=d1fe05316552
Comment 15 Mozilla RelEng Bot 2012-04-03 15:46:47 PDT
Try run for d1fe05316552 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=d1fe05316552
Results (out of 15 total builds):
    success: 15
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-d1fe05316552

Note You need to log in before you can comment on or make changes to this bug.