741468 - The user should be prompted that an app failed to install if it did fail to install

Status: VERIFIED WONTFIX

(Firefox for Android Graveyard :: Web Apps (PWAs), defect)

Description

[Jason Smith [:jsmith]]

Steps:

	1. Install the latest fennec native nightly
	2. Go to apps.mozillalabs.com/appdir
	3. Install all of the apps on this app directory (19 in total)
	4. Go to about:apps

Expected:

19 apps should be listed in about:apps.

Actual:

Only 18 out of 19 apps were listed as installed. I'm thinking that it's possible that one app failed to install, but the user was not prompted that the app failed to install.

Additional Notes:

There are likely other ways to reproduce this issue, but the above reproduction steps will consistently show the silent failure occurring during installation of one of the 19 apps.

Device: Samsung Galaxy Nexus
OS: Android 4.02
Build: Fennec Native Nightly

Comment 1

[Aaron Train [:aaronmt]]

Any specific error in the console (adb logcat)? Was there an installation prompt for all 19?

Comment 2

[Jason Smith [:jsmith]]

Yes, there was an installation prompt for all 19. I'll have dig into later what the error is in the console.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

FWIW, I don't see a way to be notified in chrome that the install failed. I only see navigator.mozMgmt.onInstall being fired for successful installs:
http://mxr.mozilla.org/mozilla-central/source/dom/base/Webapps.js#351

Is there some other event I should be listening to? I only see onInstall and onUninstall, both of which are only fired for success.

Comment 4

[Jason Smith [:jsmith]]

(In reply to Mark Finkle (:mfinkle) from comment #3)
> FWIW, I don't see a way to be notified in chrome that the install failed. I
> only see navigator.mozMgmt.onInstall being fired for successful installs:
> http://mxr.mozilla.org/mozilla-central/source/dom/base/Webapps.js#351
> 
> Is there some other event I should be listening to? I only see onInstall and
> onUninstall, both of which are only fired for success.

Sounds like this might be a problem with the API being exposed then possibly, as I thought the mozApps API does provide context into why an install failed (e.g. I couldn't find the manifest, the manifest did not parse correctly). Fabrice - Could you provide insight?

Comment 5

[[:fabrice] Fabrice Desré]

the install() call returns a DOMRequest obejct and we fire onerror on this object wen something bad happens.

So the web content has ways to notify the user of errors. I don't think this should be replicated in chrome.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

So we should close this bug?

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

As the stated in comment 3 and 5, the client-side API does not allow for reporting errors. It is currently the job of the webapp marketplace to show success and errors. I will close this bug.

Comment 8

[Jason Smith [:jsmith]]

Agreed. Marketplace does the reporting as I've seen on marketplace.mozilla.org.