741593 - [betafarm] Edit project removes project owner and member data on dev

Status: VERIFIED FIXED

(Websites :: mozillalabs.com, defect)

Description

[Rebecca Billings [:rbillings]]

Editing a project on dev removes the project owner and member data.

1) https://mozillalabs-dev.allizom.org/en-US/mozilla-hackasaurus/edit/
2) select project owners and project members > save [project is saved successfully, steps 1 & 2 are just to show that it was set up correctly]
3) https://mozillalabs-dev.allizom.org/en-US/mozilla-hackasaurus/edit/
4) click 'inactive' button > save

expected: project is saved as inactive
actual: error that fields are required, all project owners and members are no longer selected

Comment 1

[Jen Fong-Adwent [:ednapiranha]]

I can't replicate this error on my local machine.. dev needs to be updated again (currently waiting to talk to Brandon about configuration settings). Let's try this again once the server is back up.

Comment 2

[Rebecca Billings [:rbillings]]

I can easily repro this by going directly to this edit project link:
https://mozillalabs-dev.allizom.org/en-US/cash-music/edit/

and then clicking save. It immediately pulls up the error 'field is required' and I can scroll through the Project Owners list and see that no owners are selected.
** Project owners are what I see most commonly removed, the project members were being removed but I didn't see that when opening the link I posted above.

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/betafarm

https://github.com/mozilla/betafarm/commit/5af9fa75e1910a218d7d97d48afdcd018b8929f2
force cache update; fix bug 741593

https://github.com/mozilla/betafarm/commit/375c22305308200b5fcdf43d54bf94c1fbdfec5c
Merge pull request #55 from ednapiranha/bug741593

force cache update; fix bug 741593

Comment 4

[Jen Fong-Adwent [:ednapiranha]]

half of issue solved, other half is still there.. reopening

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/betafarm

https://github.com/mozilla/betafarm/commit/66a7ab702c9c39a88aadc7292c5429a17c4f0f6b
Remove django-cachemachine. Fix bug 741593.

https://github.com/mozilla/betafarm/commit/76cdba734979cbf2b2fd2fea865db6ca4c0dfd5f
Merge pull request #58 from pmclanahan/741593-edit-project-removes

Remove django-cachemachine. Fix bug 741593.

Comment 6

[Rebecca Billings [:rbillings]]

I was testing on dev this morning to verify field errors, and while editing and saving data [NOT any project owners or members] it removed the project owners:
https://mozillalabs-dev.allizom.org/en-US/verese/edit/

Comment 7

[Paul [:pmac] McLanahan]

I believe this is due to this project never having had an owner. The "Owners" field is required in the form, but there are still many projects that have no owner. So, if you try to edit one of these projects, you'll be required to choose at least one owner in order to save the form. From looking at my copy of the data, the Verese project is one of those without an owner in the database. Now that we've made the "Team Members" field not required (bug 744493), if a project is found that has team members but no owner, a team member should be moved to the owner field and all will be well.

Comment 8

[Rebecca Billings [:rbillings]]

I tested with projects that previously had this issue like Hackasaurus and am no longer able to repro the problem. Verified that projects require one owner and no members. The suggestion of moving team members to the owner field is not yet implemented.