741604 - Mozillians should be able to add more than one link to the websites field

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, enhancement)

Description

[Aakash Desai [:aakashd]]

Folks are putting in their twitter and facebook links on the bio section. There should be separate sections for them since they're another avenue to connect with a Mozillian.

Comment 1

[Aakash Desai [:aakashd]]

08:10 aakashd
what about a websites field instead of website
08:11 timw
and they can add as many fields as needed?
08:11 aakashd
as many websites into a textarea is what i'm thinking about
delimited by space, comma, et al.
08:12 timw
yes
08:12 timw
then pull in the favicon from the domain and put it in front of the link on the profile

Comment 2

[Aakash Desai [:aakashd]]

After some thought, it won't work to have a separate field for every social network...there's just too many for such a global community. Instead, let's create one multi-line field for websites and separated each link by either comma or space. These websites should show up as a vertical list of links on a user's profile.

Comment 3

[jlavoie]

Heya, sorry I've been busy/slow but I'd still like to fix this bug. Is it possible to get it reassigned to me?

Comment 4

[Aakash Desai [:aakashd]]

Hey, of course! Mike, is that alright?

Comment 5

[Mike Hoye]

Fine with me, I'm still just getting my feet wet.

Comment 6

[Michał Frontczak [:fxa90id] ♥]

can I work on it ? :)

Comment 7

[Antonio]

Hello, I saw no activity in a few days and I did a pull request fixing this bug: https://github.com/mozilla/mozillians/pull/469

Comment 8

[William Reynolds [:williamr]]

Thanks Antonio for the pull request! In the future, please ask to work on a bug before sending a pull request. We'll try to get this reviewed for you in the next few days.

Comment 9

[Antonio]

Hello William. Thanks for the info, next time I will do as you say. Sorry for any inconvenience!

Comment 10

[Antonio]

Thanks Michal for assign it to me. I am working on it!

Comment 11

[swag]

If anyone is not working on this bug..Can it be assigned to me?

Comment 12

[Justin Crawford [:hoosteeno] [:jcrawford]]

:swag, thank you for your interest! This feature is under development right this instant; the front end is already live in dev (https://mozillians-dev.allizom.org/en-US/user/edit/) and the back end will be live there soon. 

It'll launch with our next release.

Comment 13

[William Reynolds [:williamr]]

(In reply to swag from comment #11)
> If anyone is not working on this bug..Can it be assigned to me?

:swag, I'm glad you want to help with mozillians.org development! As Justin mentioned, this bug is under development already, but there are several other bugs we could use your help with. Take a look at open bugs in the Phonebook component, or say hi in the #commtools channel on IRC and we'll find a bug for your to work on. Thanks!

Comment 14

[Justin Crawford [:hoosteeno] [:jcrawford]]

Removing the target milestone while we get the backend code for this built.

Comment 15

[Justin Crawford [:hoosteeno] [:jcrawford]]

Reassigning to :sancus since he's working on it now.

Comment 16

[Rebecca Billings [:rbillings]]

I don't see the option to add more than website while editing a profile on either dev or staging.

Comment 17

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/ebb463f1fc2c2fd2cd523574731531bafd05805e
[Bug 741604] use names rather than numbers for external account types

https://github.com/mozilla/mozillians/commit/f69fe062b98bff9cdb0cb761144d8ba1cdf5f226
[Fix Bug 741604] Add multi-website support

https://github.com/mozilla/mozillians/commit/7eda89018efa3494758706f4e2e6aa5d930857c9
Merge pull request #681 from Sancus/741604-multi-websites

[Fix Bug 741604] Add multi-website support

Comment 18

[[github robot]]

Commit pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/e1ddca61975275a6b04ac5a0decd65c13b95a852
[Bug 741604] fix dict comprehension syntax in migration for python 2.6

Comment 19

[[github robot]]

Commit pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/80e03b8405b481a8ec830967c83c64a61c6b8116
[bug 741604] Remove 'website' from dev fixtures.

Comment 20

[William Reynolds [:williamr]]

Verified on stage. Through the Edit profile view, I can add or remote multiple websites in the External Accounts section. I tried different combinations of add/edit/delete, and the results were as expected and appeared properly on the view profile page.