741671 - [10.7] Remove focus ring from selected tab

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[Reuben Morais [:reuben]]

Attachment: Screenshot of iCal preferences window

On Lion, selected tabs don't have focus rings (see attached screenshot).
We should probably remove it.

Comment 1

[Reuben Morais [:reuben]]

Attachment: Screenshot of Firefox preferences window

Comment 2

[Reuben Morais [:reuben]]

Attachment: Patch

This breaks keyboard navigation between tabs (which is already kinda broken, you can only navigate with the keyboard after selecting two different tabs).

Another option would be replacing the <tabbox> with a <radiogroup> like Page Info does.

Any suggestions?

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 611906 [details] [diff] [review]
Patch

We don't want to break keyboard navigation.

Is this a CSS focus ring or native theming?

Comment 4

[Reuben Morais [:reuben]]

(In reply to Dão Gottwald [:dao] from comment #3)
> Is this a CSS focus ring or native theming?

Native theming, AFAICS.

I just spotted the Certificate Manager window, which uses <tabbox>, doesn't have the focus ring, but keyboard navigation is broken there as well.

Comment 5

[Stephen Horlander [:shorlander]]

This isn't actually highlighting the selected tab. It's a bug with focus where selecting a tab with the mouse is focusing the selected tab.

This doesn't actually present itself if the system wide "All Controls" focus setting is set because it focuses the first item on the tab sheet instead of the tab itself.

That is the correct appearance for keyboard focused tabs.

Comment 6

[Reuben Morais [:reuben]]

(In reply to Reuben Morais [:reuben] from comment #4)
> I just spotted the Certificate Manager window, which uses <tabbox>, doesn't
> have the focus ring, but keyboard navigation is broken there as well.

The weird thing is, it doesn't have any extra styling, its -moz-user-focus property has the default value of normal set in xul.css.

Comment 7

[Reuben Morais [:reuben]]

(In reply to Stephen Horlander from comment #5)
> This isn't actually highlighting the selected tab. It's a bug with focus
> where selecting a tab with the mouse is focusing the selected tab.
> 

Uh, so we have two bugs here?

1) Selecting a tab with the mouse is focusing it (not always, though).
2) Keyboard navigation of tabs is broken in Certificate Manager and Page Info.

If that's correct I'll file those bugs then.

Comment 8

[Stephen Horlander [:shorlander]]

(In reply to Reuben Morais [:reuben] from comment #7)
> 1) Selecting a tab with the mouse is focusing it (not always, though).

This seems to be the case with the Advanced preferences and Page Info. But not with the Certificate Manager or the Error Console. However Page Info has no visible focus ring even when focused.


> 2) Keyboard navigation of tabs is broken in Certificate Manager and Page
> Info.

Certificate Manager seems to be working the proper way. You can only focus those tabs if the "All Controls" preference is selected.

Also the Error Console seems to be completely broken in all states since you can never focus those tabs.

Comment 9

[Stephen Horlander [:shorlander]]

So the correct behavior should be:

1) System Settings "Text boxes and lists only" selected:
   • Tabs never selected with keyboard or mouse or by default on window open

2) System Settings "All controls" selected"
   • Tabs never selected with keyboard or mouse or by default on window open
   • Can Tab with keyboard to select the tabs and other controls
   • Focused tabs should have the blue glowy focus ring even on grey toolbars

Comment 10

[Reuben Morais [:reuben]]

We don't have native controls in settings anymore. Page Info dialog still has broken focus, but I suspect nobody cares, given how long this has been unattended. In any case, the main problem described here, about focus rings, is no longer applicable, as Page Info doesn't show them.