Last Comment Bug 741724 - clean up nsPluginHost::SetUpPluginInstance
: clean up nsPluginHost::SetUpPluginInstance
Product: Core
Classification: Components
Component: Plug-ins (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla14
Assigned To: Josh Aas
: Benjamin Smedberg [:bsmedberg]
Depends on:
  Show dependency treegraph
Reported: 2012-04-03 02:01 PDT by Josh Aas
Modified: 2012-04-04 04:56 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

fix v1.0 (2.74 KB, patch)
2012-04-03 02:01 PDT, Josh Aas
jst: review+
Details | Diff | Splinter Review

Description User image Josh Aas 2012-04-03 02:01:29 PDT
Created attachment 611745 [details] [diff] [review]
fix v1.0

We can improve nsPluginHost::SetUpPluginInstance for clarity. I believe it also has an unnecessary call to nsPluginInstanceOwner::SetInstance.
Comment 1 User image Josh Aas 2012-04-03 02:41:56 PDT
try server run:
Comment 2 User image Josh Aas 2012-04-03 15:16:35 PDT
pushed to mozilla-inbound
Comment 3 User image Marco Bonardo [::mak] 2012-04-04 04:56:01 PDT

Note You need to log in before you can comment on or make changes to this bug.