Created attachment 611838 [details] testcase See testcase, the text inputs that you see on that page are readonly, so form autocomplete popups shouldn't appear when you focus them. But in current trunk build, I do get form autocomplete popups when tapping on the inputs.
blocking-fennec1.0: --- → ?
Noming just to make sure we didn't miss something serious. Don't think it's a blocker, but maybe dev might think otherwise.
Is this also a problem with XUL fennec?
It doesn't seem to be a problem in XUL Fennec. Perhaps here, we need a check for readonly? http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#3061
(In reply to Martijn Wargers [:mw22] (QA - IRC nick: mw22) from comment #3) > It doesn't seem to be a problem in XUL Fennec. > Perhaps here, we need a check for readonly? > http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/ > browser.js#3061 XUL fennec has a similar _isAutocomplete function , but it doesn't have a check for readonly. I can't figure out exactly where that check is happening in XUL fennec However, that seems like a good place for us to check in native fennec.  http://mxr.mozilla.org/mozilla-central/source/mobile/xul/chrome/content/forms.js#579
Created attachment 617060 [details] [diff] [review] patch
Attachment #617060 - Flags: review?(mark.finkle)
Attachment #617060 - Flags: review?(mark.finkle) → review+
Comment on attachment 617060 [details] [diff] [review] patch [Approval Request Comment] Please see https://wiki.mozilla.org/Tree_Rules for information on mozilla-central landings that do not require approval. Possible risk to Fennec Native 14 (if any): very low-risk change that only affects form autocomplete (prevents suggestions from being shown on readonly inputs)
Attachment #617060 - Flags: approval-mozilla-central?
Attachment #617060 - Flags: approval-mozilla-central? → approval-mozilla-central+
Target Milestone: --- → Firefox 14
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Form autocomplete popups are not triggered on the latest Nightly and Aurora builds. Closing bug as verified fixed on: Firefox 15.0a1 (2012-05-28) Firefox 14.0a2 (2012-05-28) Device: Galaxy Nexus OS: Android 4.0.2
Status: RESOLVED → VERIFIED
status-firefox14: --- → verified
status-firefox15: --- → verified
You need to log in before you can comment on or make changes to this bug.