741831 - Readonly text inputs can trigger form autocomplete popups

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, the text inputs that you see on that page are readonly, so form autocomplete popups shouldn't appear when you focus them.
But in current trunk build, I do get form autocomplete popups when tapping on the inputs.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Noming just to make sure we didn't miss something serious.  Don't think it's a blocker, but maybe dev might think otherwise.

Comment 2

[:Margaret Leibovic]

Is this also a problem with XUL fennec?

Comment 3

[Martijn Wargers (dead)]

It doesn't seem to be a problem in XUL Fennec.
Perhaps here, we need a check for readonly?
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#3061

Comment 4

[:Margaret Leibovic]

(In reply to Martijn Wargers [:mw22] (QA - IRC nick: mw22) from comment #3)
> It doesn't seem to be a problem in XUL Fennec.
> Perhaps here, we need a check for readonly?
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/
> browser.js#3061

XUL fennec has a similar _isAutocomplete function [1], but it doesn't have a check for readonly. I can't figure out exactly where that check is happening in XUL fennec

However, that seems like a good place for us to check in native fennec.

[1] http://mxr.mozilla.org/mozilla-central/source/mobile/xul/chrome/content/forms.js#579

Comment 5

[:Margaret Leibovic]

Attachment: patch

Comment 6

[:Margaret Leibovic]

Comment on attachment 617060 [details] [diff] [review]
patch

[Approval Request Comment]
Please see https://wiki.mozilla.org/Tree_Rules for information on mozilla-central landings that do not require approval.

Possible risk to Fennec Native 14 (if any): very low-risk change that only affects form autocomplete (prevents suggestions from being shown on readonly inputs)

Comment 7

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6c8fe1624a6b

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/6c8fe1624a6b

Comment 9

[Cristian Nicolae (:xti)]

Form autocomplete popups are not triggered on the latest Nightly and Aurora builds. Closing bug as verified fixed on:

Firefox 15.0a1 (2012-05-28)
Firefox 14.0a2 (2012-05-28)

Device: Galaxy Nexus
OS: Android 4.0.2