client.mk: consolidate $(wildcard calls) to reduce overhead

RESOLVED FIXED in mozilla14

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: joey, Assigned: joey)

Tracking

unspecified
mozilla14
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Updated

5 years ago
Assignee: nobody → joey
(Assignee)

Comment 1

5 years ago
Created attachment 611848 [details] [diff] [review]
replaced [n] wildcard calls with a single call to gather files

Replaced several wildcard calls with a single call.  Cmd line length will not be an issue with only a handful of files being collected.
Attachment #611848 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 2

5 years ago
ping on the patch review
Comment on attachment 611848 [details] [diff] [review]
replaced [n] wildcard calls with a single call to gather files

Review of attachment 611848 [details] [diff] [review]:
-----------------------------------------------------------------

::: client.mk
@@ +293,5 @@
>  
>  CONFIG_STATUS_DEPS := \
> +	$(wildcard \
> +	    $(CONFIGURES) \
> +		$(TOPSRCDIR)/allmakefiles.sh \

This indentation is a little funky. Can you just make everything inside the $(wildcard) line up?
Attachment #611848 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 4

5 years ago
Created attachment 612939 [details] [diff] [review]
replaced [n] wildcard calls with a single call to gather files

Same patch logic as last time with [tab] replaced by [space] within the indentation for $(wildcard ) arguments.  r=ted
Attachment #611848 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/b23771ca17fd
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/b23771ca17fd
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

2 years ago
Blocks: 1195264
You need to log in before you can comment on or make changes to this bug.