741839 - client.mk: consolidate $(wildcard calls) to reduce overhead

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Joey Armstrong [:joey]]

Attachment: replaced [n] wildcard calls with a single call to gather files

Replaced several wildcard calls with a single call.  Cmd line length will not be an issue with only a handful of files being collected.

Comment 2

[Joey Armstrong [:joey]]

ping on the patch review

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 611848 [details] [diff] [review]
replaced [n] wildcard calls with a single call to gather files

Review of attachment 611848 [details] [diff] [review]:
-----------------------------------------------------------------

::: client.mk
@@ +293,5 @@
>  
>  CONFIG_STATUS_DEPS := \
> +	$(wildcard \
> +	    $(CONFIGURES) \
> +		$(TOPSRCDIR)/allmakefiles.sh \

This indentation is a little funky. Can you just make everything inside the $(wildcard) line up?

Comment 4

[Joey Armstrong [:joey]]

Attachment: replaced [n] wildcard calls with a single call to gather files

Same patch logic as last time with [tab] replaced by [space] within the indentation for $(wildcard ) arguments.  r=ted

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b23771ca17fd

Comment 6

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/b23771ca17fd