Last Comment Bug 741839 - client.mk: consolidate $(wildcard calls) to reduce overhead
: client.mk: consolidate $(wildcard calls) to reduce overhead
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla14
Assigned To: Joey Armstrong [:joey]
:
Mentors:
Depends on:
Blocks: 1195264
  Show dependency treegraph
 
Reported: 2012-04-03 09:28 PDT by Joey Armstrong [:joey]
Modified: 2015-08-17 05:02 PDT (History)
3 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
replaced [n] wildcard calls with a single call to gather files (1.32 KB, patch)
2012-04-03 09:39 PDT, Joey Armstrong [:joey]
ted: review+
Details | Diff | Splinter Review
replaced [n] wildcard calls with a single call to gather files (1.30 KB, patch)
2012-04-06 10:39 PDT, Joey Armstrong [:joey]
no flags Details | Diff | Splinter Review

Description Joey Armstrong [:joey] 2012-04-03 09:28:41 PDT

    
Comment 1 Joey Armstrong [:joey] 2012-04-03 09:39:22 PDT
Created attachment 611848 [details] [diff] [review]
replaced [n] wildcard calls with a single call to gather files

Replaced several wildcard calls with a single call.  Cmd line length will not be an issue with only a handful of files being collected.
Comment 2 Joey Armstrong [:joey] 2012-04-05 10:05:48 PDT
ping on the patch review
Comment 3 Ted Mielczarek [:ted.mielczarek] 2012-04-05 11:30:41 PDT
Comment on attachment 611848 [details] [diff] [review]
replaced [n] wildcard calls with a single call to gather files

Review of attachment 611848 [details] [diff] [review]:
-----------------------------------------------------------------

::: client.mk
@@ +293,5 @@
>  
>  CONFIG_STATUS_DEPS := \
> +	$(wildcard \
> +	    $(CONFIGURES) \
> +		$(TOPSRCDIR)/allmakefiles.sh \

This indentation is a little funky. Can you just make everything inside the $(wildcard) line up?
Comment 4 Joey Armstrong [:joey] 2012-04-06 10:39:19 PDT
Created attachment 612939 [details] [diff] [review]
replaced [n] wildcard calls with a single call to gather files

Same patch logic as last time with [tab] replaced by [space] within the indentation for $(wildcard ) arguments.  r=ted
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-04-06 11:14:50 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/b23771ca17fd
Comment 6 Matt Brubeck (:mbrubeck) 2012-04-09 10:09:26 PDT
https://hg.mozilla.org/mozilla-central/rev/b23771ca17fd

Note You need to log in before you can comment on or make changes to this bug.