741842 - Improve BCP 47 language tag support (extension, singleton, privateuse)

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Gordon P. Hemsley [:GPHemsley]]

I realized that bug 730209 doesn't support BCP 47 language tags that make use of extensions or private use subtags. At present, if such a language tag is the name of a dictionary, it will (I believe) display the entire language tag raw. A better behavior, I think, would be to simply ignore the extension and privateuse subtags if they are unsupported (which they currently are).

In addition, the tests included in that bug are not as exhaustive as they could be, so that should also be improved.

(I have code for this already; patch will be attached shortly.)

Comment 1

[Gordon P. Hemsley [:GPHemsley]]

Attachment: Improve support for extension and privateuse subtags

Updates the regexp and adds a bunch of tests.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 611861 [details] [diff] [review]
Improve support for extension and privateuse subtags

rs=me

Comment 3

[Gordon P. Hemsley [:GPHemsley]]

Pushed to try:
https://tbpl.mozilla.org/?tree=Try&rev=ba49a841ccef

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/62e4dcb92be0

Comment 5

[Gordon P. Hemsley [:GPHemsley]]

Ugh, I forgot to mention explicitly that this code presupposes the code for bug 716321. Since that code is not yet in m-i/m-c, I think we'll wind up with a failing test.

The test on line 106 of toolkit/content/tests/browser/browser_InlineSpellChecker.js ('es-419') should be marked as todo_is.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Changed the test to todo_is.
https://hg.mozilla.org/integration/mozilla-inbound/rev/031f54b05818

Comment 7

[Gordon P. Hemsley [:GPHemsley]]

Attachment: Improve support for extension and privateuse subtags (v2)

Here's the patch with the change integrated into, in case it's needed.

Comment 8

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/62e4dcb92be0

Comment 9

[Marco Bonardo [:mak]]

and https://hg.mozilla.org/mozilla-central/rev/031f54b05818