742008 - Firefox profiling Nightly (32-bit) fails update on Windows

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Vladan Djeric (:vladan)]

Attachment: Profile directory

My 32-bit Firefox profiling Nightly consistently fails to apply on updates on Windows 7 with: "Update could not be installed (patch apply failed)".

I've attached a zipped profile.

Comment 1

[Chris AtLee [:catlee]]

Do complete updates work?

Comment 2

[Chris AtLee [:catlee]]

sounds like bug 732526 maybe

Comment 3

[Vladan Djeric (:vladan)]

From last-update.log:

SOURCE DIRECTORY C:\Users\workvladan\AppData\Local\Mozilla\Firefox\Profiling\updates\0
DESTINATION DIRECTORY C:\Program Files (x86)\Profiling
failed: 19
calling QuitProgressUI

Comment 4

[(no longer active)]

That is CERT_VERIFY_ERROR, which suggests that the mars are not signed correctly for some reason.

Comment 5

[(no longer active)]

In particular, mar_verify_signatureW is failing.

Comment 6

[Vladan Djeric (:vladan)]

In particular, mar_verify_signatureW is failing.

Comment 7

[Vladan Djeric (:vladan)]

^^^ That was a simultaneous post conflict

(In reply to Chris AtLee [:catlee] from comment #1)
> Do complete updates work?

Yes, I am able to download a new Nightly profiling installer and "upgrade" with it.

Comment 8

[(no longer active)]

I think Chris was asking about partial versus full mar files.  In other words, if you download a nightly from a couple of days ago, and do an update (which should download something around 20MB of update data), does the update work?

Please note that "upgrading" using the installer doesn't currently use the same update code path as the regular in-browser updates.

Comment 9

[Vladan Djeric (:vladan)]

(In reply to Ehsan Akhgari [:ehsan] from comment #8)
> In other words, if you download a nightly from a couple of days ago, and do an update
> (which should download something around 20MB of update data), does the
> update work?

I downloaded the latest ~20MB .mar file, saved it as update.mar in the updates\0\ directory and got the same "Update could not be installed (patch apply failed)" error

Comment 10

[Chris AtLee [:catlee]]

Ehsan, can you dig into this more? Or maybe Brian can help debug?

Comment 11

[(no longer active)]

(In reply to Chris AtLee [:catlee] from comment #10)
> Ehsan, can you dig into this more? Or maybe Brian can help debug?

What do you need me to do here?  I don't know how I would fix the mar signatures for this branch!

Comment 12

[Chris AtLee [:catlee]]

are we sure they're bad?

Comment 13

[Brian R. Bondy [:bbondy]]

I'm looking into the MARs now, I'll update here when I have info.

Comment 14

[(no longer active)]

(In reply to Chris AtLee [:catlee] from comment #12)
> are we sure they're bad?

Yes, unless you're implying that we might have bugs on the client side, which is outrageous!  ;-)

Comment 15

[Brian R. Bondy [:bbondy]]

ehsan++

Comment 16

[Chris AtLee [:catlee]]

are you implying there are bugs with the signing!?!?!?!!?

Comment 17

[Brian R. Bondy [:bbondy]]

The full and partial MAR from 2012-04-20 verify with DER file from 
toolkit\mozapps\update\updater\nightly_aurora_level3_primary.der

That cert is determined from the logic here by the way:
toolkit\mozapps\update\updater\Makefile.in

I also checked the MARs from 2012-04-03 and 2012-04-04 and they verify properly as well.  

Do you by chance have this registry location?:
SOFTWARE\Mozilla\MaintenanceService\3932ecacee736d366d6436db0f55bce4
It is used for running tests, and if set it will use the xpcshell cert instead of the normal one.

Comment 18

[Brian R. Bondy [:bbondy]]

Also if you can get this error again, please give me your updater.exe in a zip attached to this bug.  I'll verify that the embedded cert file is correct.

Comment 19

[Brian R. Bondy [:bbondy]]

I tried downloading the 2012-04-02 build which I presume you had since this was first reported on 2012-04-03 and it updated correctly.  Can you confirm that was the build you were using? 

Could you try uninstalling, then re-installing that same build.  Does it work for you?

Is it possibly the mar file was corrupted while being downloaded?

Comment 20

[(no longer active)]

Brian, I assume these last questions are addressed at Vladan, right?

Comment 21

[Brian R. Bondy [:bbondy]]

Yes sorry. Comment 17, Comment 18, and Comment 19 were addressed at vladan.

Comment 22

[Vladan Djeric (:vladan)]

(In reply to Brian R. Bondy [:bbondy] from comment #17)
> Do you by chance have this registry location?:
> SOFTWARE\Mozilla\MaintenanceService\3932ecacee736d366d6436db0f55bce4
> It is used for running tests, and if set it will use the xpcshell cert
> instead of the normal one.

Yup, it turns out this is what was causing the Firefox updates to fail.