Last Comment Bug 742091 - Texture format detection broken by 740372
: Texture format detection broken by 740372
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: ARM Linux
: -- normal (vote)
: mozilla14
Assigned To: Oleg Romashin (:romaxa)
:
:
Mentors:
http://bubblemark.com/dhtml.htm
Depends on:
Blocks: 740372 741745
  Show dependency treegraph
 
Reported: 2012-04-03 16:20 PDT by Oleg Romashin (:romaxa)
Modified: 2012-04-05 23:47 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Raw patch, need to check non-mobile-optimize build (1.51 KB, patch)
2012-04-03 16:20 PDT, Oleg Romashin (:romaxa)
no flags Details | Diff | Splinter Review
Seems to work everywhere (1.65 KB, patch)
2012-04-03 17:10 PDT, Oleg Romashin (:romaxa)
gwright: review+
Details | Diff | Splinter Review
Fix texture format Image format, add comment back (1.71 KB, patch)
2012-04-04 14:26 PDT, Oleg Romashin (:romaxa)
romaxa: review+
Details | Diff | Splinter Review

Description Oleg Romashin (:romaxa) 2012-04-03 16:20:53 PDT
Created attachment 612007 [details] [diff] [review]
Raw patch, need to check non-mobile-optimize build

http://mxr.mozilla.org/mozilla-central/source/gfx/gl/GLContextProviderEGL.cpp#851 - become broken after moving mobile optimize into common content<->format optimizer..

I guess android XUL builds also got RGB/BGR colors swapped
Comment 1 Oleg Romashin (:romaxa) 2012-04-03 17:10:58 PDT
Created attachment 612031 [details] [diff] [review]
Seems to work everywhere
Comment 2 George Wright (:gw280) (:gwright) 2012-04-04 14:18:16 PDT
Comment on attachment 612031 [details] [diff] [review]
Seems to work everywhere

Review of attachment 612031 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

::: gfx/gl/GLContextProviderEGL.cpp
@@ -866,5 @@
>          } else {
> -            if (mUpdateFormat == gfxASurface::ImageFormatRGB24) {
> -                // RGB24 means really RGBX for Thebes, which means we have to
> -                // use the right shader and ignore the uninitialized alpha
> -                // value.

Can you add this comment back in?
Comment 3 Oleg Romashin (:romaxa) 2012-04-04 14:26:56 PDT
Created attachment 612337 [details] [diff] [review]
Fix texture format Image format, add comment back

Note You need to log in before you can comment on or make changes to this bug.