742091 - Texture format detection broken by 740372

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Oleg Romashin (:romaxa)]

Attachment: Raw patch, need to check non-mobile-optimize build

http://mxr.mozilla.org/mozilla-central/source/gfx/gl/GLContextProviderEGL.cpp#851 - become broken after moving mobile optimize into common content<->format optimizer..

I guess android XUL builds also got RGB/BGR colors swapped

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Seems to work everywhere

Comment 2

[George Wright (:gw280) (needinfo me!)]

Comment on attachment 612031 [details] [diff] [review]
Seems to work everywhere

Review of attachment 612031 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

::: gfx/gl/GLContextProviderEGL.cpp
@@ -866,5 @@
>          } else {
> -            if (mUpdateFormat == gfxASurface::ImageFormatRGB24) {
> -                // RGB24 means really RGBX for Thebes, which means we have to
> -                // use the right shader and ignore the uninitialized alpha
> -                // value.

Can you add this comment back in?

Comment 3

[Oleg Romashin (:romaxa)]

Attachment: Fix texture format Image format, add comment back

Comment 4

[Oleg Romashin (:romaxa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/77a9eff9bf12

Comment 5

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/77a9eff9bf12