Texture format detection broken by 740372

RESOLVED FIXED in mozilla14

Status

()

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
mozilla14
ARM
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

()

Attachments

(2 attachments, 1 obsolete attachment)

http://mxr.mozilla.org/mozilla-central/source/gfx/gl/GLContextProviderEGL.cpp#851 - become broken after moving mobile optimize into common content<->format optimizer..

I guess android XUL builds also got RGB/BGR colors swapped
Assignee: nobody → romaxa
Attachment #612007 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #612031 - Flags: review?(gwright)
Comment on attachment 612031 [details] [diff] [review]
Seems to work everywhere

Review of attachment 612031 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

::: gfx/gl/GLContextProviderEGL.cpp
@@ -866,5 @@
>          } else {
> -            if (mUpdateFormat == gfxASurface::ImageFormatRGB24) {
> -                // RGB24 means really RGBX for Thebes, which means we have to
> -                // use the right shader and ignore the uninitialized alpha
> -                // value.

Can you add this comment back in?
Attachment #612031 - Flags: review?(gwright) → review+
http://hg.mozilla.org/mozilla-central/rev/77a9eff9bf12
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.