742111 - J-PAKE text entry boxes not focused in pair a device on Transformer Prime

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Nick Alexander :nalexander [he/him]]

I tried to use Android Sync to pair my desktop to my Android Transformer Prime (so I was typing in the code on the device).  The text entry boxes were not immediately focused, so I had no keyboard -- very disorienting.  I tapped the first box, and everything worked, but it was unclear how to proceed initially.

Comment 1

[Allison Naaktgeboren :ally]

fixed on develop (github)

Comment 2

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/9e62b7df0d3c

Comment 3

[Nick Alexander :nalexander [he/him]]

On my Transformer Prime, the entry box is now focused, but...
- the keyboard is not shown by default
- the textboxes auto-complete

Re-opened to try to fix these issues.  I think we want 

android:inputType="textVisiblePassword"

for the latter problem.

Comment 4

[Chenxia Liu [:liuche]]

Should keyboard be shown by default? On phones, showing the keyboard will hide most of the screen, so it's not clear that there are 3 text entry boxes, where you enter the three rows of J-PAKE pin.

On autocomplete, is this referring to autocorrect? Autocorrect is fixed in a patch for bug 739906, not a beta blocker and therefore languishing.

Comment 5

[Nick Alexander :nalexander [he/him]]

(In reply to Chenxia Liu [:liuche] from comment #4)
> Should keyboard be shown by default? On phones, showing the keyboard will
> hide most of the screen, so it's not clear that there are 3 text entry
> boxes, where you enter the three rows of J-PAKE pin.

Deferring to your judgement here on what is best.

> On autocomplete, is this referring to autocorrect? Autocorrect is fixed in a
> patch for bug 739906, not a beta blocker and therefore languishing.

I think so.  Glad to see this is in the works; let's leave this open and depend on 739906.

Comment 6

[Richard Newman [:rnewman]]

(In reply to Nick Alexander :nalexander from comment #5)
> (In reply to Chenxia Liu [:liuche] from comment #4)
> > Should keyboard be shown by default? On phones, showing the keyboard will
> > hide most of the screen, so it's not clear that there are 3 text entry
> > boxes, where you enter the three rows of J-PAKE pin.
> 
> Deferring to your judgement here on what is best.

We are targeting phones, not tablets, so don't automatically show. Leaving to ally to decide if that means this bug is closed, or if we want to loop in UX here.

Comment 7

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7fe9ee19f09f

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7fe9ee19f09f