742137 - Run ISPDB on Django 1.4

Status: RESOLVED INVALID

(Webtools :: ISPDB Server, defect)

Description

[Sergio Roberto]

Attachment: ispdb-django1.4.patch

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_8) AppleWebKit/535.19 (KHTML, like Gecko) Chrome/18.0.1025.142 Safari/535.19

Steps to reproduce:

Modified ISPDB so it can run on Django 1.4. Also convert.py was broken (it should work with config files from svn, but should be revised).

Comment 1

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 612061 [details]
ispdb-django1.4.patch

This looks good to me, and all the tests pass.

Thanks,
Blake.

Comment 2

[Blake Winton (:bwinton) (:☕️)]

(Also, I totally don't have access to that repo anymore, cause I haven't used it in a while, so I'm going to ask Sancus to do the actual commit.  ;)

Comment 3

[Sankarshan.Mudkavi]

Hey, shouldn't you change the function based test runner to a class based test runner for Django 1.4?
That is: set TEST_RUNNER = 'django_nose.run_tests' to TEST_RUNNER = 'django_nose.NoseTestSuiteRunner'

Sankarshan.

Comment 4

[Sergio Roberto]

Yes. Also, I did not get though these items in the last patch (but I'm working on it):
- modify settings under apache/ dir
- ADMIN_MEDIA_PREFIX has been removed in v1.4. Django is looking for admin static files in STATIC_URL/admin. Since we are using "admin_media" as prefix URL for admin files, it should be changed in web server conf (change the alias).
- STATIC_URL, STATIC_ROOT, STATICFILES_DIRS and STATICFILES_FINDERS were added to settings. Statics files (css, .js, etc.) should be placed in static dir whereas user uploaded files, or app created files goes to media dir : https://docs.djangoproject.com/en/dev/howto/static-files/ . The recommended way to work with static files is to create a static folder under each app dir and run collectstatic to copy all the static files into STATIC_ROOT. 

Because these items depend on modifications on the project directory tree (and on webserver conf). Are we going to move to the new layout (using statics subfolder, and collectstatic component) or keep with static files under /media and just change admin alias? Or any other ideas?

Comment 5

[Ryan VanderMeulen [:RyanVM]]

So, was Sancus going to check this in?

Comment 6

[Andrei Hajdukewycz [:sancus]]

r104687 - thanks for the patch.

We should move to the Django 1.4 style of doing static files; this site should frankly be taken out of production until it's actually ready for it, so preserving existing web server setups isn't important at all.

Additionally, I'm planning to move this repo to github to make things easier for contributors.

Comment 7

[Sergio Roberto]

Ok. I will provide a new patch for the last revision, with the items on comment #4.