Need to support the 'float' type in the WebIDL parser

RESOLVED FIXED in mozilla15

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bz, Assigned: khuey)

Tracking

(Blocks: 1 bug)

Trunk
mozilla15
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 612067 [details] [diff] [review]
Maybe patch

Right now, the parser dies on it.

Attached patch makes things work, but may be bogus.
Attachment #612067 - Attachment description: Maybe patc → Maybe patch
Created attachment 619526 [details] [diff] [review]
Patch

The "Maybe patch" fixes this, but it's a step in the wrong direction because it makes float consts more broken than they already are.  This patch doesn't make float consts any worse.
Attachment #612067 - Attachment is obsolete: true
Attachment #619526 - Flags: review?(justin.lebar+bug)
So FLOAT_ is the "float" keyword, while FLOAT is a floating-point literals?

If so, can we indicate in the token names which are keywords and which are literals, by putting a prefix / suffix on the names?  That would be helpful for sanity, I think.  (It looks like the spec does this, using "Literal" as a suffix for the literals tokens.)
Comment on attachment 619526 [details] [diff] [review]
Patch

r=me, but I'd really prefer for us to change to a saner set of token names.  But you can do that as a followup if you'd like...
Attachment #619526 - Flags: review?(justin.lebar+bug) → review+
Float and FloatLiteral sound good to me.  The *Literal stuff is pretty new in the spec, I think.
http://hg.mozilla.org/users/khuey_mozilla.com/webidl-parser/rev/3e01e8dc99b6
http://hg.mozilla.org/mozilla-central/rev/f1a9dac39546
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Flags: in-testsuite+
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.