Closed Bug 742151 Opened 8 years ago Closed 7 years ago

WebIDL parser's error reporting seems to not be very good with line numbers

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

I was getting error reports at "line 1:4" for a wide variety of actual error locations today...
Attached patch Failing testSplinter Review
Doesn't seem to work for me.
Assignee: khuey → bzbarsky
Whiteboard: [need review]
Comment on attachment 629320 [details] [diff] [review]
Fix the error reporting in the WebIDL parser to list correct line numbers.   are two changes here.  One is to pass tracking=True to our parser.  This makes it properly track positions

Review of attachment 629320 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #629320 - Flags: review?(khuey) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/db893d2f7d04
Flags: in-testsuite+
Whiteboard: [need review]
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/db893d2f7d04
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.