The default bug view has changed. See this FAQ.

WebIDL parser's error reporting seems to not be very good with line numbers

RESOLVED FIXED in mozilla16

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

(Blocks: 1 bug)

Trunk
mozilla16
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

I was getting error reports at "line 1:4" for a wide variety of actual error locations today...
I think this is fixed now.
Created attachment 617789 [details] [diff] [review]
Failing test

Doesn't seem to work for me.
Created attachment 629320 [details] [diff] [review]
Fix the error reporting in the WebIDL parser to list correct line numbers.   are two changes here.  One is to pass tracking=True to our parser.  This makes it properly track positions
Attachment #629320 - Flags: review?(khuey)
Assignee: khuey → bzbarsky
Whiteboard: [need review]
Comment on attachment 629320 [details] [diff] [review]
Fix the error reporting in the WebIDL parser to list correct line numbers.   are two changes here.  One is to pass tracking=True to our parser.  This makes it properly track positions

Review of attachment 629320 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #629320 - Flags: review?(khuey) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/db893d2f7d04
Flags: in-testsuite+
Whiteboard: [need review]
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/db893d2f7d04
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.