Closed
Bug 742168
Opened 12 years ago
Closed 12 years ago
ParisBindingsEnabled should be renamed
Categories
(Core :: DOM: Core & HTML, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
3.89 KB,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
Maybe ExperimentalBindingsEnabled(), since this pref will only control the moving edge of the conversion?
Comment 1•12 years ago
|
||
Shrug - I think Paris bindings is a fine way to refer to the "new dom bindings that aren't nodelists". I don't think it's any more confusing to have 'paris_bindings' control the moving edge of this stuff than it is to have 'new_bindings' control the moving edge of nodelist stuff. I'm fine with changing it too - I just don't think it's really worth the effort.
Assignee | ||
Comment 2•12 years ago
|
||
I think this would be really confusing to new contributors, who would then start searching about for what the hecko this "Paris" thing has to do with anything and come up empty. Note that I think the nodelist situation is also silly, naming-wise. ;)
Assignee | ||
Comment 3•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → bzbarsky
Whiteboard: [need review]
Assignee | ||
Updated•12 years ago
|
Attachment #613363 -
Flags: review?(peterv)
Assignee | ||
Updated•12 years ago
|
Priority: -- → P2
Comment 4•12 years ago
|
||
I don't think the nodelist naming is silly personally, I think we should merge the two prefs instead after the next train.
Updated•12 years ago
|
Attachment #613363 -
Flags: review?(peterv) → review+
Assignee | ||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/projects/birch/rev/abc682ac7eee That said, do we want to get this into 14, since it changes the pref name?
Flags: in-testsuite-
Whiteboard: [need review] → [need birch merge]
Target Milestone: --- → mozilla15
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/abc682ac7eee
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [need birch merge]
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•