742176 - Text frames have an overflow area which is too small on Windows

Status: RESOLVED WORKSFORME

(Core :: Layout: Text and Fonts, defect)

Description

[(no longer active)]

See bug 157681 comment 71 for steps to reproduce!

Comment 1

[(no longer active)]

Note that the work-around in attachment 612095 [details] [diff] [review] should be removed once this bug is fixed.

Comment 2

[Jonathan Kew [:jfkthame]]

Is this still a problem, or can we resolve it as WFM? It looks to me like "the work-around in attachment 612095 [details] [diff] [review]" never actually landed in the tree....

Comment 3

[(no longer active)]

The workarounds landed as fuzzy-if annotations: https://dxr.mozilla.org/mozilla-central/search?q=742176

I guess you can remove them and see if the tests fail to see if this is still an issue...

Comment 4

[Jonathan Kew [:jfkthame]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7fcb137e197c

Comment 5

[Jonathan Kew [:jfkthame]]

(In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!) from comment #3)
> The workarounds landed as fuzzy-if annotations:
> https://dxr.mozilla.org/mozilla-central/search?q=742176
> 
> I guess you can remove them and see if the tests fail to see if this is
> still an issue...

See try run in comment 4. Note that only one of the tests failed, and it's apparently less "fuzzy" than it used to be, judging by the numbers in the annotation.

Also, checking the reftest analyzer images, the discrepancy is NOT at the boundaries of the area being drawn, as we'd expect if it's a problem with visual overflow areas. Rather, it's one of the mid-word glyphs that is rendered with slightly different subpixel antialiasing between the testcase and reference. That's not an indication of overflow-area problems.

Comment 6

[(no longer active)]

It's very well possible that the original issue has been fixed, or it still exists but this test case doesn't hit it any more.  I don't think this bug is actionable any more.

Comment 7

[Jonathan Kew [:jfkthame]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6acc56430efa

Comment 8

[Jonathan Kew [:jfkthame]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0722a92fa07e

Comment 9

[Jonathan Kew [:jfkthame]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=af3ad5fe431f

Comment 10

[Jonathan Kew [:jfkthame]]

Attachment: Remove/reduce fuzz annotations for tests that no longer appear to be affected by bad overflow areas

OK, I propose we tighten up the annotations on these tests, and then we'll close this as WorksForMe given that we're not seeing overflow-area issues here any more.

Comment 11

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ee5ce5ae72e0

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ee5ce5ae72e0