Closed Bug 742179 Opened 8 years ago Closed 8 years ago

Move MakeRandomString to xpcom/ds

Categories

(Core :: XPCOM, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: dougt, Assigned: dougt)

Details

Attachments

(1 file)

http://mxr.mozilla.org/mozilla-central/ident?i=MakeRandomString

This function and its associated table is used in two places.  I am considering also using it for a very similar purpose.  I'd like to move it into xpcom/ds - probably nsCRT
Attached patch patch v.1Splinter Review
Assignee: nobody → doug.turner
Attachment #612098 - Flags: review?(dbaron)
Comment on attachment 612098 [details] [diff] [review]
patch v.1

Please make this NS_GetRandomString and put it in nsCRTGlue.h/cpp instead of nsCRT which is supposed to be going away. r=me with that change.
Attachment #612098 - Flags: review?(dbaron) → review+
This landed as https://hg.mozilla.org/integration/mozilla-inbound/rev/118c07dc56f9
...but it caused windows build bustage:
https://tbpl.mozilla.org/php/getParsedLog.php?id=10670071&tree=Mozilla-Inbound
{
error LNK2019: unresolved external symbol __imp_PR_Now referenced in function "void __cdecl NS_MakeRandomString(char *,int)" (?NS_MakeRandomString@@YAXPEADH@Z)
}
...so I backed it out as https://hg.mozilla.org/integration/mozilla-inbound/rev/290dd1ca19b6
Version: unspecified → Trunk
Uses of NSPR in xpcom/glue need ifdefs for standalone glue.
And #include "nsCRTGlue.h" instead of #include "nsCRT.h"
https://hg.mozilla.org/mozilla-central/rev/b46d76d90cc0
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.