742179 - Move MakeRandomString to xpcom/ds

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Doug Turner (:dougt)]

http://mxr.mozilla.org/mozilla-central/ident?i=MakeRandomString

This function and its associated table is used in two places.  I am considering also using it for a very similar purpose.  I'd like to move it into xpcom/ds - probably nsCRT

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[Benjamin Smedberg]

Comment on attachment 612098 [details] [diff] [review]
patch v.1

Please make this NS_GetRandomString and put it in nsCRTGlue.h/cpp instead of nsCRT which is supposed to be going away. r=me with that change.

Comment 3

[Daniel Holbert [:dholbert]]

This landed as https://hg.mozilla.org/integration/mozilla-inbound/rev/118c07dc56f9
...but it caused windows build bustage:
https://tbpl.mozilla.org/php/getParsedLog.php?id=10670071&tree=Mozilla-Inbound
{
error LNK2019: unresolved external symbol __imp_PR_Now referenced in function "void __cdecl NS_MakeRandomString(char *,int)" (?NS_MakeRandomString@@YAXPEADH@Z)
}
...so I backed it out as https://hg.mozilla.org/integration/mozilla-inbound/rev/290dd1ca19b6

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Uses of NSPR in xpcom/glue need ifdefs for standalone glue.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

And #include "nsCRTGlue.h" instead of #include "nsCRT.h"

Comment 6

[Doug Turner (:dougt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b46d76d90cc0

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b46d76d90cc0