Closed Bug 742189 Opened 13 years ago Closed 10 years ago

Workers need to stop using hand-coded DOMJSClass

Categories

(Core :: DOM: Workers, defect)

Product:
Core
Component:
DOM: Workers
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: bzbarsky, Unassigned)

References

(Blocks 1 open bug)

Details

We're OK for now because of the static asserts, but it makes it a bit more pain to add new bindings (due to maybe having to fix worker code). The plan, as I understand, is to move the things using these DOMJSClasses to codegen.
Component: DOM → DOM: Workers
QA Contact: general → workers
Blocks: 742193
So we need an actual plan here. Right now, this stuff is all pretty broken. For example, "new Worker().__proto__.__proto__ == EventTarget.prototype" tests false, because workers stick an EventTarget_workers on their proto chain manually! I expect part of the problem is that new Worker can happen in both windows and workers, right? Seems to me like generally speaking we need a mainthread-style impl for the former (with CC and such, possibly) and a worker-style impl for the latter...
Seems fixed.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.