optional jsval arguments ('any' in the IDL) should become JSVAL_VOID, not JSVAL_NULL, when there was no argument passed

RESOLVED FIXED in mozilla14

Status

()

Core
DOM
P2
normal
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

(Blocks: 1 bug)

Trunk
mozilla14
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Right now we do JSVAL_NULL converted to the argument type for all optional arguments without a default value.
Actually, I think we can just use JSVAL_VOID across the board here; for everything but string arguments it's identical, and for string arguments I think the JSVAL_VOID behavior is more per spec.
Created attachment 613374 [details] [diff] [review]
Like so
Assignee: nobody → bzbarsky
Attachment #613374 - Flags: review?(peterv)
Priority: -- → P2
Whiteboard: [need review]
Attachment #613374 - Flags: review?(peterv) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/a021e58d714f
Flags: in-testsuite?
Whiteboard: [need review]
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/a021e58d714f
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.