Last Comment Bug 742200 - optional jsval arguments ('any' in the IDL) should become JSVAL_VOID, not JSVAL_NULL, when there was no argument passed
: optional jsval arguments ('any' in the IDL) should become JSVAL_VOID, not JSV...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: x86 Mac OS X
: P2 normal (vote)
: mozilla14
Assigned To: Boris Zbarsky [:bz] (still a bit busy)
:
:
Mentors:
Depends on:
Blocks: ParisBindings
  Show dependency treegraph
 
Reported: 2012-04-03 22:05 PDT by Boris Zbarsky [:bz] (still a bit busy)
Modified: 2012-04-11 09:04 PDT (History)
3 users (show)
bzbarsky: in‑testsuite?
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Like so (674 bytes, patch)
2012-04-09 13:24 PDT, Boris Zbarsky [:bz] (still a bit busy)
peterv: review+
Details | Diff | Splinter Review

Description Boris Zbarsky [:bz] (still a bit busy) 2012-04-03 22:05:58 PDT
Right now we do JSVAL_NULL converted to the argument type for all optional arguments without a default value.
Comment 1 Boris Zbarsky [:bz] (still a bit busy) 2012-04-09 13:24:12 PDT
Actually, I think we can just use JSVAL_VOID across the board here; for everything but string arguments it's identical, and for string arguments I think the JSVAL_VOID behavior is more per spec.
Comment 2 Boris Zbarsky [:bz] (still a bit busy) 2012-04-09 13:24:47 PDT
Created attachment 613374 [details] [diff] [review]
Like so
Comment 3 Boris Zbarsky [:bz] (still a bit busy) 2012-04-10 10:13:48 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/a021e58d714f
Comment 4 Matt Brubeck (:mbrubeck) 2012-04-11 09:04:30 PDT
https://hg.mozilla.org/mozilla-central/rev/a021e58d714f

Note You need to log in before you can comment on or make changes to this bug.