Closed Bug 742200 Opened 8 years ago Closed 8 years ago

optional jsval arguments ('any' in the IDL) should become JSVAL_VOID, not JSVAL_NULL, when there was no argument passed

Categories

(Core :: DOM: Core & HTML, defect, P2)

x86
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Right now we do JSVAL_NULL converted to the argument type for all optional arguments without a default value.
Actually, I think we can just use JSVAL_VOID across the board here; for everything but string arguments it's identical, and for string arguments I think the JSVAL_VOID behavior is more per spec.
Attached patch Like soSplinter Review
Assignee: nobody → bzbarsky
Attachment #613374 - Flags: review?(peterv)
Priority: -- → P2
Whiteboard: [need review]
Attachment #613374 - Flags: review?(peterv) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/a021e58d714f
Flags: in-testsuite?
Whiteboard: [need review]
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/a021e58d714f
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.