Closed Bug 742219 Opened 10 years ago Closed 10 years ago

Add a "Trunk" tree that combines mozilla-central and mozilla-inbound, and make it the default tree

Categories

(Tree Management Graveyard :: OrangeFactor, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: philor, Assigned: emorley)

Details

Attachments

(1 file)

At the time, bug 657815 was right that the default view should be mozilla-central, because that was the trunk, the active tree, the one that showed how we were doing. Now, however, that's the tree that gets a very few pushes a day, and if you aren't adding in mozilla-inbound, you're getting an inadequate sample of a sixth as many pushes as you should be getting.
billm: I have never gotten orange factor to work properly for me. the numbers all seem wrong.
billm: it seems to miss a ton of stuff
billm: I go to http://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=763450&startday=2012-05-28&endday=2012-06-25&tree=mozilla-central
billm: it shows 10 instances. but the bugzilla bug shows 107
edmorley: that view is mozilla-central only (dropdown top left of screen)
billm: ah!
Attached patch Patch v1Splinter Review
* Adds 'Trunk' to the client side tree selection & makes it the default.
* Adds a new 'trunk_trees' pref to server/orangefactor.conf.example (we'll need this adding to the dev/staging/prod instances of this config file, which I presume don't get checked in), which server/handlers.py then uses to deal with &tree=[tT]runk

Untested since I don't have access to the ES server to try out the server side changes & can't test the client side due to bug 769290.
Assignee: nobody → bmo
Status: NEW → ASSIGNED
Attachment #637518 - Flags: review?(mcote)
Comment on attachment 637518 [details] [diff] [review]
Patch v1

Looks good.
Attachment #637518 - Flags: review?(mcote) → review+
http://hg.mozilla.org/automation/orangefactor/rev/b2bf6b48bb14
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Deployed to brasstacks.
Product: Testing → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.