Closed
Bug 74225
Opened 23 years ago
Closed 23 years ago
Prefs needed for focus appearance
Categories
(SeaMonkey :: Preferences, defect)
SeaMonkey
Preferences
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: aaronlev, Assigned: aaronlev)
Details
(Keywords: access)
Attachments
(3 files)
9.89 KB,
patch
|
Details | Diff | Splinter Review | |
10.92 KB,
patch
|
Details | Diff | Splinter Review | |
13.07 KB,
patch
|
Details | Diff | Splinter Review |
Some users have a difficult time seeing where the keyboard focus is in content. The 1px dotted line isn't easy to see. It's currently possible for a savvy user to change their userContent.css file with a :focus rule, but that's too difficult. A set of prefs are needed, so the user can change the foreground and background color of the focus, or change with width of the dotted line. SetBoolPref("browser.display.use_focus_colors", useFocusColors); SetCharPref("browser.display.focus_background_color", colorString); SetCharPref("browser.display.focus_text_color", colorString); SetCharPref("browser.display.focus_ring_width", numPixels); /* 0-4 */
Assignee | ||
Comment 1•23 years ago
|
||
Assignee | ||
Comment 2•23 years ago
|
||
One more pref was added with the patch: SetBoolPref("browser.display.focus_ring_on_anything", true /* or false */); This defaults to false - it makes focus rings to show on anything that gets focused, including text fields. This is useful for users who cannot discern the focus from color alone.
Assignee | ||
Comment 3•23 years ago
|
||
Attinasi, looking at the SetFocusRules method I added to nsPresContext.cpp, how would you recommend i fix the :link:unvisited, :link:visited part so that buttons and images and everything that currently gets a focus ring, gets the rule?
Assignee | ||
Comment 4•23 years ago
|
||
Comment 5•23 years ago
|
||
Minor issue, in the code in nsPresContext you should use if (NS_SUCCEEDED( instead of: if (NS_OK == It seems like the right thing to do, althoug it is unclear to me whether this is always done, and it seems like it always overrides anything in the stylestheets r=rods
Assignee | ||
Comment 6•23 years ago
|
||
Comment 7•23 years ago
|
||
nsPresContext.h - PRBool should be PRPackedBool for class data members nsPresShell.cpp - tabs need to be replaced by spaces: I see several occurances (try <shift><ctrl>8 in MSVC to see the tabs, if you have windows). Other than that, sr=attinasi
Assignee | ||
Comment 8•23 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Updated•23 years ago
|
Component: Style System → Preferences
QA Contact: ian → sairuh
Comment 9•23 years ago
|
||
yep, those prefs are in defaults/prefs/all.js --looking at my 2001.08.15.08-comm installation on linux, my settings are: pref("browser.display.use_focus_colors", false); pref("browser.display.focus_background_color", "#117722"); pref("browser.display.focus_text_color", "#ffffff"); pref("browser.display.focus_ring_width", 1);
Status: RESOLVED → VERIFIED
Comment 10•23 years ago
|
||
oops, for linux-comm builds tested: s/2001.08.15.08/2001.08.15.14
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•