74225 - Prefs needed for focus appearance

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Aaron Leventhal]

Some users have a difficult time seeing where the keyboard focus is in content.
The 1px dotted line isn't easy to see. It's currently possible for a savvy user
to change their userContent.css file with a :focus rule, but that's too
difficult. A set of prefs are needed, so the user can change the foreground and
background color of the focus, or change with width of the dotted line.

SetBoolPref("browser.display.use_focus_colors", useFocusColors);
SetCharPref("browser.display.focus_background_color", colorString);
SetCharPref("browser.display.focus_text_color", colorString);
SetCharPref("browser.display.focus_ring_width", numPixels); /* 0-4 */

Comment 1

[Aaron Leventhal]

Attachment: Patch adds 5 focus appearance prefs

Comment 2

[Aaron Leventhal]

One more pref was added with the patch:
SetBoolPref("browser.display.focus_ring_on_anything", true /* or false */);

This defaults to false - it makes focus rings to show on anything that gets
focused, including text fields. This is useful for users who cannot discern the
focus from color alone.

Comment 3

[Aaron Leventhal]

Attinasi, looking at the SetFocusRules method I added to nsPresContext.cpp, how
would you recommend i fix the :link:unvisited, :link:visited part so that
buttons and images and everything that currently gets a focus ring, gets the
rule?

Comment 4

[Aaron Leventhal]

Attachment: This version fixes border widths on buttons too

Comment 5

[rods (gone)]

Minor issue, in the code in nsPresContext you should use 
if (NS_SUCCEEDED(

instead of:
if (NS_OK == 

It seems like the right thing to do, althoug it is unclear to me whether this is 
always done, and it seems like it always overrides anything in the stylestheets

r=rods

Comment 6

[Aaron Leventhal]

Attachment: Fixes all (NS_OK == blah) to NS_SUCCEEDED in methods I touch

Comment 7

[Marc Attinasi]

nsPresContext.h
- PRBool should be PRPackedBool for class data members

nsPresShell.cpp
- tabs need to be replaced by spaces: I see several occurances (try
<shift><ctrl>8 in MSVC to see the tabs, if you have windows).

Other than that, sr=attinasi 

Comment 8

[Aaron Leventhal]

Fix checked in.

Comment 9

[sairuh (rarely reading bugmail)]

yep, those prefs are in defaults/prefs/all.js --looking at my 2001.08.15.08-comm
installation on linux, my settings are:

pref("browser.display.use_focus_colors",    false);
pref("browser.display.focus_background_color", "#117722");
pref("browser.display.focus_text_color",     "#ffffff");
pref("browser.display.focus_ring_width",     1);

Comment 10

[sairuh (rarely reading bugmail)]

oops, for linux-comm builds tested: s/2001.08.15.08/2001.08.15.14