Last Comment Bug 742261 - Remove useless queryCommandText/execCommandShowHelp methods
: Remove useless queryCommandText/execCommandShowHelp methods
Status: RESOLVED FIXED
: addon-compat, dev-doc-complete
Product: Core
Classification: Components
Component: Editor (show other bugs)
: Trunk
: All All
: -- enhancement (vote)
: mozilla14
Assigned To: Aryeh Gregor (:ayg) (away until October 25)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-04 05:08 PDT by Aryeh Gregor (:ayg) (away until October 25)
Modified: 2012-04-29 13:18 PDT (History)
4 users (show)
ayg: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (5.10 KB, patch)
2012-04-04 05:31 PDT, Aryeh Gregor (:ayg) (away until October 25)
ehsan: review+
Details | Diff | Splinter Review

Description Aryeh Gregor (:ayg) (away until October 25) 2012-04-04 05:08:27 PDT
These are non-standard, and all they do is throw exceptions anyway.
Comment 1 Aryeh Gregor (:ayg) (away until October 25) 2012-04-04 05:31:20 PDT
Created attachment 612157 [details] [diff] [review]
Patch v1
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2012-04-04 05:32:20 PDT
Nice.
Comment 3 :Ehsan Akhgari 2012-04-04 10:06:44 PDT
Comment on attachment 612157 [details] [diff] [review]
Patch v1

Review of attachment 612157 [details] [diff] [review]:
-----------------------------------------------------------------

You need to change the IID of nsIDOMHTMLDocument.  r=me with that.

Also, before landing, please do the following:

1. Please file an issue with firebug to get them to remove these two methods from the list of DOM methods they recognize.
2. Please search the comm-central MXR for these two methods to make sure they are not being used there.

Thanks!
Comment 4 Mozilla RelEng Bot 2012-04-05 07:31:31 PDT
Autoland Patchset:
	Patches: 612157
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=59c0ad0d1673
Try run started, revision 59c0ad0d1673. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=59c0ad0d1673
Comment 5 Mozilla RelEng Bot 2012-04-05 12:17:20 PDT
Try run for 59c0ad0d1673 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=59c0ad0d1673
Results (out of 218 total builds):
    exception: 2
    success: 181
    warnings: 35
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-59c0ad0d1673
Comment 6 Aryeh Gregor (:ayg) (away until October 25) 2012-04-06 00:38:08 PDT
(In reply to Ehsan Akhgari [:ehsan] from comment #3)
> You need to change the IID of nsIDOMHTMLDocument.  r=me with that.

Okay, will do.

> Also, before landing, please do the following:
> 
> 1. Please file an issue with firebug to get them to remove these two methods
> from the list of DOM methods they recognize.

http://code.google.com/p/fbug/issues/detail?id=5374&thanks=5374&ts=1333697823

> 2. Please search the comm-central MXR for these two methods to make sure
> they are not being used there.

I see them in this IDL file:

http://mxr.mozilla.org/comm-central/source/mozilla/dom/interfaces/html/nsIDOMHTMLDocument.idl

I'm guessing this file is synced somehow from mozilla-central and I don't need to worry about it?  I don't see any other instances.
Comment 7 Aryeh Gregor (:ayg) (away until October 25) 2012-04-06 00:57:14 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/f40757e78476
Comment 8 Matt Brubeck (:mbrubeck) 2012-04-06 11:49:08 PDT
https://hg.mozilla.org/mozilla-central/rev/f40757e78476
Comment 9 :Ehsan Akhgari 2012-04-07 11:31:18 PDT
(In reply to Aryeh Gregor from comment #6)
> I see them in this IDL file:
> 
> http://mxr.mozilla.org/comm-central/source/mozilla/dom/interfaces/html/
> nsIDOMHTMLDocument.idl
> 
> I'm guessing this file is synced somehow from mozilla-central and I don't
> need to worry about it?  I don't see any other instances.

Yeah, comm-central is built with a m-c checkout under the mozilla/ directory, and MXR indexes that too.

Note You need to log in before you can comment on or make changes to this bug.