742261 - Remove useless queryCommandText/execCommandShowHelp methods

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Description

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

These are non-standard, and all they do is throw exceptions anyway.

Comment 1

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Patch v1

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Nice.

Comment 3

[(no longer active)]

Comment on attachment 612157 [details] [diff] [review]
Patch v1

Review of attachment 612157 [details] [diff] [review]:
-----------------------------------------------------------------

You need to change the IID of nsIDOMHTMLDocument.  r=me with that.

Also, before landing, please do the following:

1. Please file an issue with firebug to get them to remove these two methods from the list of DOM methods they recognize.
2. Please search the comm-central MXR for these two methods to make sure they are not being used there.

Thanks!

Comment 4

[Mozilla RelEng Bot]

Autoland Patchset:
	Patches: 612157
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=59c0ad0d1673
Try run started, revision 59c0ad0d1673. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=59c0ad0d1673

Comment 5

[Mozilla RelEng Bot]

Try run for 59c0ad0d1673 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=59c0ad0d1673
Results (out of 218 total builds):
    exception: 2
    success: 181
    warnings: 35
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-59c0ad0d1673

Comment 6

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

(In reply to Ehsan Akhgari [:ehsan] from comment #3)
> You need to change the IID of nsIDOMHTMLDocument.  r=me with that.

Okay, will do.

> Also, before landing, please do the following:
> 
> 1. Please file an issue with firebug to get them to remove these two methods
> from the list of DOM methods they recognize.

http://code.google.com/p/fbug/issues/detail?id=5374&thanks=5374&ts=1333697823

> 2. Please search the comm-central MXR for these two methods to make sure
> they are not being used there.

I see them in this IDL file:

http://mxr.mozilla.org/comm-central/source/mozilla/dom/interfaces/html/nsIDOMHTMLDocument.idl

I'm guessing this file is synced somehow from mozilla-central and I don't need to worry about it?  I don't see any other instances.

Comment 7

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f40757e78476

Comment 8

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/f40757e78476

Comment 9

[(no longer active)]

(In reply to Aryeh Gregor from comment #6)
> I see them in this IDL file:
> 
> http://mxr.mozilla.org/comm-central/source/mozilla/dom/interfaces/html/
> nsIDOMHTMLDocument.idl
> 
> I'm guessing this file is synced somehow from mozilla-central and I don't
> need to worry about it?  I don't see any other instances.

Yeah, comm-central is built with a m-c checkout under the mozilla/ directory, and MXR indexes that too.

Comment 10

[Eric Shepherd [:sheppy]]

Documents updated:

https://developer.mozilla.org/en/DOM_Client_Object_Cross-Reference/document
https://developer.mozilla.org/en/DOM/document
https://developer.mozilla.org/en/XPCOM_Interface_Reference/nsIDOMNSHTMLDocument

Mentioned on Firefox 14 for developers.