Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Remove useless queryCommandText/execCommandShowHelp methods

RESOLVED FIXED in mozilla14

Status

()

Core
Editor
--
enhancement
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ayg, Assigned: ayg)

Tracking

({addon-compat, dev-doc-complete})

Trunk
mozilla14
addon-compat, dev-doc-complete
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

These are non-standard, and all they do is throw exceptions anyway.
Created attachment 612157 [details] [diff] [review]
Patch v1
Attachment #612157 - Flags: review?(ehsan)
Nice.
Whiteboard: [autoland-try:-u all]

Updated

5 years ago
Whiteboard: [autoland-try:-u all] → [autoland-in-queue]
Comment on attachment 612157 [details] [diff] [review]
Patch v1

Review of attachment 612157 [details] [diff] [review]:
-----------------------------------------------------------------

You need to change the IID of nsIDOMHTMLDocument.  r=me with that.

Also, before landing, please do the following:

1. Please file an issue with firebug to get them to remove these two methods from the list of DOM methods they recognize.
2. Please search the comm-central MXR for these two methods to make sure they are not being used there.

Thanks!
Attachment #612157 - Flags: review?(ehsan) → review+
Keywords: addon-compat, dev-doc-needed

Comment 4

5 years ago
Autoland Patchset:
	Patches: 612157
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=59c0ad0d1673
Try run started, revision 59c0ad0d1673. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=59c0ad0d1673

Comment 5

5 years ago
Try run for 59c0ad0d1673 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=59c0ad0d1673
Results (out of 218 total builds):
    exception: 2
    success: 181
    warnings: 35
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-59c0ad0d1673
(In reply to Ehsan Akhgari [:ehsan] from comment #3)
> You need to change the IID of nsIDOMHTMLDocument.  r=me with that.

Okay, will do.

> Also, before landing, please do the following:
> 
> 1. Please file an issue with firebug to get them to remove these two methods
> from the list of DOM methods they recognize.

http://code.google.com/p/fbug/issues/detail?id=5374&thanks=5374&ts=1333697823

> 2. Please search the comm-central MXR for these two methods to make sure
> they are not being used there.

I see them in this IDL file:

http://mxr.mozilla.org/comm-central/source/mozilla/dom/interfaces/html/nsIDOMHTMLDocument.idl

I'm guessing this file is synced somehow from mozilla-central and I don't need to worry about it?  I don't see any other instances.
https://hg.mozilla.org/integration/mozilla-inbound/rev/f40757e78476
Flags: in-testsuite+
Target Milestone: --- → mozilla14

Updated

5 years ago
Whiteboard: [autoland-in-queue]
https://hg.mozilla.org/mozilla-central/rev/f40757e78476
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(In reply to Aryeh Gregor from comment #6)
> I see them in this IDL file:
> 
> http://mxr.mozilla.org/comm-central/source/mozilla/dom/interfaces/html/
> nsIDOMHTMLDocument.idl
> 
> I'm guessing this file is synced somehow from mozilla-central and I don't
> need to worry about it?  I don't see any other instances.

Yeah, comm-central is built with a m-c checkout under the mozilla/ directory, and MXR indexes that too.
Documents updated:

https://developer.mozilla.org/en/DOM_Client_Object_Cross-Reference/document
https://developer.mozilla.org/en/DOM/document
https://developer.mozilla.org/en/XPCOM_Interface_Reference/nsIDOMNSHTMLDocument

Mentioned on Firefox 14 for developers.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.