GCC 4.8 mingw fails to compile cairo due to missing ffs declaration

RESOLVED FIXED in mozilla14

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla14
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 612177 [details] [diff] [review]
fix v1.0

Like in case of MSVC, there is no ffs in win32. GCC has __builtin_ffs, so we may simply use it (for MSVC it's implemented in cairo-compiler-private.h using _BitScanForward).
Attachment #612177 - Flags: review?(jmuizelaar)
Comment on attachment 612177 [details] [diff] [review]
fix v1.0

Please add a patch to the gfx/cairo/
Attachment #612177 - Flags: review?(jmuizelaar) → review+
(Assignee)

Comment 2

5 years ago
Thanks for review, pushed with a patch file:

https://hg.mozilla.org/integration/mozilla-inbound/rev/80bbc7983052
Assignee: nobody → jacek
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/80bbc7983052
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.