Closed
Bug 742361
Opened 12 years ago
Closed 12 years ago
GCC 4.8 mingw fails to compile cairo due to missing ffs declaration
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: jacek, Assigned: jacek)
Details
Attachments
(1 file)
|
959 bytes,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
Like in case of MSVC, there is no ffs in win32. GCC has __builtin_ffs, so we may simply use it (for MSVC it's implemented in cairo-compiler-private.h using _BitScanForward).
Attachment #612177 -
Flags: review?(jmuizelaar)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 612177 [details] [diff] [review] fix v1.0 Please add a patch to the gfx/cairo/
Attachment #612177 -
Flags: review?(jmuizelaar) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
Thanks for review, pushed with a patch file: https://hg.mozilla.org/integration/mozilla-inbound/rev/80bbc7983052
Assignee: nobody → jacek
Target Milestone: --- → mozilla14
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/80bbc7983052
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•