742381 - Duplicate default bookmarks

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[:Margaret Leibovic]

This may be a problem with a sync account I've been using for testing, but I have duplicate versions of the default bookmarks in my mobile bookmarks folder (on both desktop and mobile), and this seems like something we could avoid.

Comment 1

[:Margaret Leibovic]

Also, because of bug 741630, this makes duplicate default bookmarks show up in "Top Sites", and that looks really bad.

Comment 2

[Tracy Walker [:tracy]]

Margaret, can you reproduce this with a clean profile/account?  If your account is over a few weeks old it could have been exposed to some early bookmark reconciling bugs.  If you can reproduce please attach appropriate logs. Thanks for your help.

Comment 3

[:Margaret Leibovic]

(In reply to Tracy Walker [:tracy] from comment #2)
> Margaret, can you reproduce this with a clean profile/account?  If your
> account is over a few weeks old it could have been exposed to some early
> bookmark reconciling bugs.  If you can reproduce please attach appropriate
> logs. Thanks for your help.

I wasn't able to reproduce with a clean profile/account, even after syncing multiple new fennec profiles, so this problems appears to be fixed. However, should we try to clean up profiles that were exposed to these bookmark reconciling bugs?

Comment 4

[Allison Naaktgeboren :ally]

Is it even feasible to clean up profiles that were exposed to the reconciliation issues?

Comment 5

[Richard Newman [:rnewman]]

(In reply to :Ally Naaktgeboren from comment #4)
> Is it even feasible to clean up profiles that were exposed to the
> reconciliation issues?

Hard to say. People who've been testing from the alpha days will have screwed up local data, screwed up data on the server, and perhaps even screwed up (primarily duplicate) data on other machines.

Cleaning up a desktop and then Reset Sync > Replace Others will help: right now it'll clean the server, so a new Android Sync setup will be fine.

When we've implemented wipe handling in Android Sync this will also recover existing setups.

In your case, Margaret, you probably have dupes visible in your desktop. Try deleting all of those, then Prefs > Sync > Manage… Reset Sync > Replace others with the contents of this device. Then uninstall Fennec and start again. If that still causes dupes, then I'd be concerned.

Thanks for filing!

Comment 6

[:Margaret Leibovic]

(In reply to Richard Newman [:rnewman] from comment #5)
> (In reply to :Ally Naaktgeboren from comment #4)
> > Is it even feasible to clean up profiles that were exposed to the
> > reconciliation issues?
> 
> Hard to say. People who've been testing from the alpha days will have
> screwed up local data, screwed up data on the server, and perhaps even
> screwed up (primarily duplicate) data on other machines.
> 
> Cleaning up a desktop and then Reset Sync > Replace Others will help: right
> now it'll clean the server, so a new Android Sync setup will be fine.
> 
> When we've implemented wipe handling in Android Sync this will also recover
> existing setups.
> 
> In your case, Margaret, you probably have dupes visible in your desktop. Try
> deleting all of those, then Prefs > Sync > Manage… Reset Sync > Replace
> others with the contents of this device. Then uninstall Fennec and start
> again. If that still causes dupes, then I'd be concerned.

Yes, this fixes the problem. I'd be fine with a decision to WONTFIX this bug, since this profile likely got borked long ago. I feel like users who decided to use very early versions of sync should also be okay needing to do some manual fixing-up, like I just had to do :)

Comment 7

[Allison Naaktgeboren :ally]

mobile triage: not a blocker & a wontfix