74242 - Live window resizing on Mac OS X [FizzillaCFM]

Status: VERIFIED FIXED

(Core :: XUL, defect, P4)

Description

[Henri Sivonen (:hsivonen)]

Build: Fizzilla CFM 2001-03-28

Reproducible: Always

Steps to reproduce:
1) Open a browser window.
2) Drag the window size box.

Expected results:
Expected window to be dynamically resized with the layout updating as in OmniWeb
on Mac OS X or Mozilla on Windows 2000.

Actual results:
Only a gray border is dragged as in Classic.

Comment 1

[Peter Trudelle]

->pink/p4, probably future unless trivial

Comment 2

[Mike Pinkerton (not reading bugmail)]

yeah, it's trivial from what i remember reading.

Comment 3

[Mike Pinkerton (not reading bugmail)]

moving my osx bugs to 0.9.2

Comment 4

[Mike Pinkerton (not reading bugmail)]

Attachment: [patch] make it work

Comment 5

[Mike Pinkerton (not reading bugmail)]

patch attached, took me 2 hours. carbon events are neat-o

Comment 6

[Mike Pinkerton (not reading bugmail)]

smfr, can i get an sr?

Comment 7

[Simon Fraser [no longer active]]

... NewEventHandlerUPP(WindowEventHandler) ... 
Don't you need to dispose the UPP somewhere?

The WindowEventHandler should probably check the return value of 
GetEventParameter(), and for a non-null WindowRef.

Might want to check the return value of InstallWindowEventHandler too.

Comment 8

[Mike Pinkerton (not reading bugmail)]

- no, according to the docs the UPP is freed for you when the target goes away
if you pass NULL as the final param to the install

- will make that null-check

- why bother? if it fails to install, the event handler is never called, and
it's hardly a failure if it doesn't install. it's not mission-critical.

Comment 9

[Simon Fraser [no longer active]]

Why check the return value of InstallWindowEventHandler()? Because if you don't, 
we have no way of knowing if it works. Assert on failure, or something. But I 
guess it doesn't matter that much.

Comment 10

[Simon Fraser [no longer active]]

sr=sfraser with the null check

Comment 11

[Mike Pinkerton (not reading bugmail)]

r=saari. i added an assert to make smfr happy ;)

Comment 12

[Asa Dotzler [:asa]]

a= [e-mail] (on behalf of drivers). 

Comment 13

[Mike Pinkerton (not reading bugmail)]

checked in.

Comment 14

[Chris Petersen]

Marking verified in the June 5th Fizzilla build.