Closed
Bug 742425
Opened 13 years ago
Closed 13 years ago
Remove the compartment-entering in WrapNewBindingObject
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
2.71 KB,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
I talked to Blake and jorendorff; the claim is that cx and JS_THIS should always be in the same compartment for a jsnative, and since we pass the JS_THIS as the scope to WrapNewBindingObject, we can just assert that we're in the right compartment.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #612245 -
Flags: review?(peterv)
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [need review]
|
||
Comment 2•13 years ago
|
||
Comment on attachment 612245 [details] [diff] [review]
Remove the extra compartment-entering code we don't need.
Review of attachment 612245 [details] [diff] [review]:
-----------------------------------------------------------------
(In reply to Boris Zbarsky (:bz) from comment #0)
> the claim is that cx and JS_THIS should
> always be in the same compartment for a jsnative
That'll be true for obj too if we don't use JSPROP_NATIVE_ACCESSORS, right?
Attachment #612245 -
Flags: review?(peterv) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
> That'll be true for obj too if we don't use JSPROP_NATIVE_ACCESSORS, right?
Yes.
|
|
Assignee | |
Comment 4•13 years ago
|
||
Flags: in-testsuite-
Whiteboard: [need review] → [need birch merge]
Target Milestone: --- → mozilla15
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [need birch merge]
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•