The default bug view has changed. See this FAQ.

Remove the compartment-entering in WrapNewBindingObject

RESOLVED FIXED in mozilla15

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

(Blocks: 1 bug)

Trunk
mozilla15
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

I talked to Blake and jorendorff; the claim is that cx and JS_THIS should always be in the same compartment for a jsnative, and since we pass the JS_THIS as the scope to WrapNewBindingObject, we can just assert that we're in the right compartment.
Created attachment 612245 [details] [diff] [review]
Remove the extra compartment-entering code we don't need.
Attachment #612245 - Flags: review?(peterv)
Whiteboard: [need review]
Comment on attachment 612245 [details] [diff] [review]
Remove the extra compartment-entering code we don't need.

Review of attachment 612245 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Boris Zbarsky (:bz) from comment #0)
> the claim is that cx and JS_THIS should
> always be in the same compartment for a jsnative

That'll be true for obj too if we don't use JSPROP_NATIVE_ACCESSORS, right?
Attachment #612245 - Flags: review?(peterv) → review+
> That'll be true for obj too if we don't use JSPROP_NATIVE_ACCESSORS, right?

Yes.
https://hg.mozilla.org/projects/birch/rev/b6f1af93a4e6
Flags: in-testsuite-
Whiteboard: [need review] → [need birch merge]
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/b6f1af93a4e6
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [need birch merge]
You need to log in before you can comment on or make changes to this bug.