Note: There are a few cases of duplicates in user autocompletion which are being worked on.

'make marionette' test command needed for gaia

RESOLVED FIXED in mozilla14

Status

Testing
Marionette
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mdas, Assigned: mdas)

Tracking

Trunk
mozilla14
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

We need to create a `make marionette` command for use with the gaia/ repository to make testing easier. This will require code check-in on m-c and in the gaia/ repo.

m-c code will see changes in the marionette client, so it can execute a b2g desktop binary.

gaia code changes will be the actual make command.
Assignee: nobody → mdas
Created attachment 612318 [details] [diff] [review]
marionette client changes

This patch allows the marionette client to start a b2g desktop instance from an executable (and passes it the needed profile information), as used by the gaia team.

This patch creates a class that handles the running b2g instance and modifies runtests.py and marionette.py accordingly.
Attachment #612318 - Flags: review?(jgriffin)
Comment on attachment 612318 [details] [diff] [review]
marionette client changes

Review of attachment 612318 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good with a few minor changes:

::: testing/marionette/client/marionette/b2ginstance.py
@@ +13,5 @@
> +        self.b2gbin = b2gbin
> +        self.proc = None
> +
> +    def start(self):
> +        args = [self.b2gbin, '-profile', os.path.join(os.getenv('GAIA'), "profile")]

We should probably verify that os.getenv('GAIA') points to something real, and throw if not.

@@ +14,5 @@
> +        self.proc = None
> +
> +    def start(self):
> +        args = [self.b2gbin, '-profile', os.path.join(os.getenv('GAIA'), "profile")]
> +        args = ["/Users/mdas/Code/other-moz/mozilla/obj-b2g-desktop/dist/bin/b2g", '-profile', os.path.join(os.getenv('GAIA'), "profile")]

Looks like some debugging code was left in here.

::: testing/marionette/client/marionette/runtests.py
@@ +184,5 @@
>                                              connectToRunningEmulator=True,
>                                              homedir=self.homedir,
>                                              baseurl=self.baseurl)
> +            if self.b2gbin:
> +                self.marionette = Marionette(host=host, port=int(port), b2gbin=self.b2gbin)

We should include the baseurl parameter with this instantiation of Marionette; the 'baseurl' is the root address of Marionette's webserver.
Attachment #612318 - Flags: review?(jgriffin) → review+
Created attachment 612335 [details] [diff] [review]
Updated patch

Fixed the patch and tested it.
Attachment #612318 - Attachment is obsolete: true
Attachment #612335 - Flags: review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/fdac8905b6de
Target Milestone: --- → mozilla14
http://hg.mozilla.org/mozilla-central/rev/fdac8905b6de
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.