Last Comment Bug 742562 - IonMonkey: Inline allocation for JSOP_NEWARRAY
: IonMonkey: Inline allocation for JSOP_NEWARRAY
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Sean Stangl [:sstangl]
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks: IonSpeed
  Show dependency treegraph
 
Reported: 2012-04-04 15:29 PDT by Sean Stangl [:sstangl]
Modified: 2012-04-04 21:13 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Inline allocation for JSOP_NEWARRAY. (4.47 KB, patch)
2012-04-04 17:56 PDT, Sean Stangl [:sstangl]
dvander: review+
Details | Diff | Splinter Review

Description Sean Stangl [:sstangl] 2012-04-04 15:29:24 PDT
JSOP_NEWOBJECT should use the MacroAssembler's getNewObject() path where possible. In terms of benchmarks, this mostly affects v8-splay; 3d-cube; and a few kraken tests, especially crypto-ccm.
Comment 1 Sean Stangl [:sstangl] 2012-04-04 15:30:30 PDT
Ahem, that should have read JSOP_NEWARRAY.
Comment 2 Sean Stangl [:sstangl] 2012-04-04 17:56:18 PDT
Created attachment 612418 [details] [diff] [review]
Inline allocation for JSOP_NEWARRAY.

Brings splay 125ms -> 112ms. Combined with JSOP_NEWOBJECT patch, splay goes from 125ms -> 82ms. 3d-cube goes from ~35ms to ~32ms, not a significant change.
Comment 3 Sean Stangl [:sstangl] 2012-04-04 21:13:20 PDT
https://hg.mozilla.org/projects/ionmonkey/rev/d20c0126f0f9

Note You need to log in before you can comment on or make changes to this bug.