The default bug view has changed. See this FAQ.

IonMonkey: Inline allocation for JSOP_NEWARRAY

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: sstangl, Assigned: sstangl)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
JSOP_NEWOBJECT should use the MacroAssembler's getNewObject() path where possible. In terms of benchmarks, this mostly affects v8-splay; 3d-cube; and a few kraken tests, especially crypto-ccm.
(Assignee)

Comment 1

5 years ago
Ahem, that should have read JSOP_NEWARRAY.
(Assignee)

Updated

5 years ago
Assignee: general → sstangl
(Assignee)

Comment 2

5 years ago
Created attachment 612418 [details] [diff] [review]
Inline allocation for JSOP_NEWARRAY.

Brings splay 125ms -> 112ms. Combined with JSOP_NEWOBJECT patch, splay goes from 125ms -> 82ms. 3d-cube goes from ~35ms to ~32ms, not a significant change.
Attachment #612418 - Flags: review?(dvander)
Attachment #612418 - Flags: review?(dvander) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/projects/ionmonkey/rev/d20c0126f0f9
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.